Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cheqd): cheqd revocationRegistryDefinition resource name #2139

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DaevMithran
Copy link
Contributor

This PR fixes resource name collisions for revocation registries with different tags.

Creating two revocation registries with same name's will lead to updating the resource. Adding credential definition tag in the resource name will fix this issue

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: 4649982

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@credo-ts/cheqd Patch
@credo-ts/action-menu Patch
@credo-ts/anoncreds Patch
@credo-ts/askar Patch
@credo-ts/bbs-signatures Patch
@credo-ts/core Patch
@credo-ts/didcomm Patch
@credo-ts/drpc Patch
@credo-ts/indy-sdk-to-askar-migration Patch
@credo-ts/indy-vdr Patch
@credo-ts/node Patch
@credo-ts/openid4vc Patch
@credo-ts/question-answer Patch
@credo-ts/react-native Patch
@credo-ts/tenants Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: DaevMithran <[email protected]>
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some notes

@@ -26,7 +26,7 @@
"test": "jest"
},
"dependencies": {
"@cheqd/sdk": "^2.5.1",
"@cheqd/sdk": "^2.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should properly test this in RN. We have to pin everything to a very specific version or the SDK breaks. Even with the current version it throws an unhandled promise rejection on startup (due to wasm errors) but it somehow still works for resolving.

We haven't had the time to properly look into it, but before we can merge this we should first test it in react native (actually we should pin the version to 2.5.1 for now, instead of using ^2.5.1 until it's fixed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting it! It would be very helpful if you can create an issue on our sdk with context-rich logs or reproduction steps. Thanks

Copy link
Contributor Author

@DaevMithran DaevMithran Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimoGlastra after our mainnet upgrade we got some feedback that Cheqd transactions from credo are failing, and you can also see that some of the integration tests are failing in 2.5.1. This must be due to insufficient gas after introducing our fee market module, In our latest sdk we have fixed the default gas fees. We have not made any major dependency changes from 2.5.1 to 2.6.0

@DaevMithran DaevMithran requested a review from a team as a code owner January 9, 2025 04:58
@TimoGlastra
Copy link
Contributor

Sorry about the delay for this. It seems CI is now failing due to support missing for BigInt:

Error: ../node_modules/.pnpm/@cheqd[email protected]/node_modules/@cheqd/ts-proto/google/protobuf/timestamp.ts(176,29): error TS2737: BigInt literals are not available when targeting lower than ES2020.

I've check and BigInt is available in Node.JS and React Native now so I think we can update our target to ES2020 so resolve this.

@TimoGlastra
Copy link
Contributor

I've created this PR to update the target: #2156. Once that is merged we can merge this PR.

I will also try to get a PR pushed with support for the latest version of the Cheqd SDK, as well as the related cosmo dependencies. I'll then create an example app with the issues we encounter with cheqd in react native

@TimoGlastra
Copy link
Contributor

Found a first issue with updating the Cheqd SDK: cheqd/sdk#400

@DaevMithran
Copy link
Contributor Author

Found a first issue with updating the Cheqd SDK: cheqd/sdk#400

@TimoGlastra for cjs in cheqd. we have fixed them at version: 2.x or tag: cjs in sdk and ts-proto and we are maintaining it actively. The latest versions only support esm (some packages may not be compatible in react native like cosmjs).

@TimoGlastra
Copy link
Contributor

The latest version (5.x) also published a CJS version still, however it doesn't work correctly as ts-proto does not publish CJS on the latest version. So i think it makes sense to remove the CJS build from the newer (5.x) releases.

@TimoGlastra
Copy link
Contributor

#2156 has been merged, can you update this branch with main?

@TimoGlastra
Copy link
Contributor

sorry one more thing 😬 , Can you accept this PR (i can't make updates to your branch if you create the PR from an org account)

cheqd#8

@TimoGlastra
Copy link
Contributor

@DaevMithran it seems a test related to cheqd failed

@DaevMithran
Copy link
Contributor Author

@DaevMithran it seems a test related to cheqd failed

@TimoGlastra Can we rereun it.

The error was A jest worker process (pid=7356) crashed for an unknown reason: exitCode=0 only in E2E(20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants