-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cheqd): cheqd revocationRegistryDefinition resource name #2139
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: DaevMithran <[email protected]>
🦋 Changeset detectedLatest commit: 4649982 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: DaevMithran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Some notes
packages/cheqd/src/anoncreds/services/CheqdAnonCredsRegistry.ts
Outdated
Show resolved
Hide resolved
packages/cheqd/package.json
Outdated
@@ -26,7 +26,7 @@ | |||
"test": "jest" | |||
}, | |||
"dependencies": { | |||
"@cheqd/sdk": "^2.5.1", | |||
"@cheqd/sdk": "^2.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should properly test this in RN. We have to pin everything to a very specific version or the SDK breaks. Even with the current version it throws an unhandled promise rejection on startup (due to wasm errors) but it somehow still works for resolving.
We haven't had the time to properly look into it, but before we can merge this we should first test it in react native (actually we should pin the version to 2.5.1 for now, instead of using ^2.5.1 until it's fixed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting it! It would be very helpful if you can create an issue on our sdk with context-rich logs or reproduction steps. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimoGlastra after our mainnet upgrade we got some feedback that Cheqd transactions from credo are failing, and you can also see that some of the integration tests are failing in 2.5.1. This must be due to insufficient gas after introducing our fee market module, In our latest sdk we have fixed the default gas fees. We have not made any major dependency changes from 2.5.1 to 2.6.0
Signed-off-by: DaevMithran <[email protected]>
Signed-off-by: DaevMithran <[email protected]>
Sorry about the delay for this. It seems CI is now failing due to support missing for BigInt:
I've check and BigInt is available in Node.JS and React Native now so I think we can update our target to ES2020 so resolve this. |
I've created this PR to update the target: #2156. Once that is merged we can merge this PR. I will also try to get a PR pushed with support for the latest version of the Cheqd SDK, as well as the related cosmo dependencies. I'll then create an example app with the issues we encounter with cheqd in react native |
Found a first issue with updating the Cheqd SDK: cheqd/sdk#400 |
@TimoGlastra for cjs in cheqd. we have fixed them at |
The latest version (5.x) also published a CJS version still, however it doesn't work correctly as ts-proto does not publish CJS on the latest version. So i think it makes sense to remove the CJS build from the newer (5.x) releases. |
#2156 has been merged, can you update this branch with main? |
sorry one more thing 😬 , Can you accept this PR (i can't make updates to your branch if you create the PR from an org account) |
Signed-off-by: DaevMithran <[email protected]>
@DaevMithran it seems a test related to cheqd failed |
@TimoGlastra Can we rereun it. The error was |
This PR fixes resource name collisions for revocation registries with different tags.
Creating two revocation registries with same name's will lead to updating the resource. Adding credential definition tag in the resource name will fix this issue