Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add biomejs #2175

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sairanjit
Copy link
Contributor

Summary

Tasks

  • Fix formatting
  • Fix Linting
  • Migrate initial required rules to biomejs
  • Update eslint-disable-next-line to biome-ignore
  • Update the scripts in package.json
  • Update commands in CI/CD

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: fb39533

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sairanjit
Copy link
Contributor Author

cc: @TimoGlastra @berendsliedrecht This is a starting point for migrating to biomejs. Do you have any thoughts on additional points I should consider beyond what I’ve already mentioned?

@TimoGlastra
Copy link
Contributor

I think the list looks good! Could you create a list of which eslint rules you haven't added biome rules for yet?

I think for me I'd like to have support for:

  • import/no-cycle
  • @typescript-eslint/consistent-type-imports
  • @typescript-eslint/no-non-null-assertion
  • import/no-extraneous-dependencies
  • no-restricted-imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants