Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: credo as holder and jsonld issuance + verification #80

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

GHkrishna
Copy link
Contributor

What:

  • Add Credo support instead of older AFJ
  • Add JSONLD issuance and verification support

@GHkrishna GHkrishna force-pushed the feat/credo-holder-jsonld-issuance branch 3 times, most recently from e61c8a7 to 3d785ea Compare November 15, 2024 12:01
Copy link
Contributor

@anwalker293 anwalker293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GHkrishna! We have a PR already approved (waiting on one change) to move from AFJ to credo as the holder. Could you just make this PR for jsonLD issuance and verification please? And can you please remove the Indicio-demonet files from everything? (The demonet for Indicio won't work / requires manual approval to anchor an endorser DID)

@GHkrishna
Copy link
Contributor Author

GHkrishna commented Nov 19, 2024

Actually most of the testing for JSON-LD(issuance/verification) has been done with Credo and not AFJ, so will it be okay to keep the changes in the PR as is and only merge this PR when the credo as holder PR merges.

@anwalker293
Copy link
Contributor

@GHkrishna Credo has been merged into owl-akrida

@GHkrishna
Copy link
Contributor Author

Sure, had some minor changes, will sync

Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna GHkrishna force-pushed the feat/credo-holder-jsonld-issuance branch from e85b5c5 to 8eeb406 Compare December 2, 2024 07:57
@GHkrishna
Copy link
Contributor Author

GHkrishna commented Dec 2, 2024

I have updated the branch and made some changes, however I m facing some issues with schema interoperability between ACA-py and credo specifically for verification. Issuance works fine.
Not sure, if we can merge it until we figure that out or wait for its resolution, need your suggestion. I'll update the detailed error

@anwalker293
Copy link
Contributor

@GHkrishna Could we have more information on what you're seeing? re: schemas

@GHkrishna
Copy link
Contributor Author

GHkrishna commented Dec 3, 2024

In ACA-py, according to this resource the uri for schema in presentation request is https://w3id.org/citizenship#PermanentResident however in credo its only https://w3id.org/citizenship for this example. This causes issue with schema resolution on credo's side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants