-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: credo as holder and jsonld issuance + verification #80
base: main
Are you sure you want to change the base?
feat: credo as holder and jsonld issuance + verification #80
Conversation
e61c8a7
to
3d785ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GHkrishna! We have a PR already approved (waiting on one change) to move from AFJ to credo as the holder. Could you just make this PR for jsonLD issuance and verification please? And can you please remove the Indicio-demonet files from everything? (The demonet for Indicio won't work / requires manual approval to anchor an endorser DID)
Actually most of the testing for JSON-LD(issuance/verification) has been done with Credo and not AFJ, so will it be okay to keep the changes in the PR as is and only merge this PR when the credo as holder PR merges. |
@GHkrishna Credo has been merged into owl-akrida |
Sure, had some minor changes, will sync |
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Krishna Waske <[email protected]>
e85b5c5
to
8eeb406
Compare
I have updated the branch and made some changes, however I m facing some issues with schema interoperability between ACA-py and credo specifically for verification. Issuance works fine. |
@GHkrishna Could we have more information on what you're seeing? re: schemas |
In ACA-py, according to this resource the uri for schema in presentation request is |
What:
Credo
support instead of older AFJ