luci-app-attendedsysupgrade: apply changes to package list #7610
Conversation
...luci-app-attendedsysupgrade/htdocs/luci-static/resources/view/attendedsysupgrade/overview.js
Outdated
Show resolved
Hide resolved
|
Seems to work, amazing |
Utilize the 'package_changes' from the ASU server to update the package list for the build request. Links: openwrt/asu@2bff208 Signed-off-by: Eric Fahlgren <[email protected]>
efahl
force-pushed
the
package-changes
branch
from
f959bcd to
23f5b48
Compare
I know, right? 😂 Took me like 50 iterations reworking all that Promises.all and contents to get something that worked. |
|
Looks legit and clean. If it works - even better 😁 |
|
It should be backport to 24 and 23 |
Alas, it does not. 😞 I just found a bug, I used |
24 is an easy cherrypick as we've kept it current with main. How should I handle 23? It's way behind and has a ton of diffs, but it all appears to work if I just copy it to my 23.05.5 test box. Does a cherry pick work on all that or is there some other way to get the changes merged? |
|
cherry-pick PR including the bug fix from #7611 (?) sounds like the natural approach for 24.10. 23.05 looks more problematic, as there are so many commits in master that have not been backported to 23.05 already earlier. Trying to backport only the latest commit might lead into new problems. |
|
I'd backport it all, the state of the 23er luci app is unable to update to 24.10 |
Utilize the 'package_changes' from the ASU server to update the package list for the build request.
Links: openwrt/asu@2bff208
@aparcar @systemcrash Please critique these changes thoroughly, my JS experience is grossly outdated and I'm not at all confident about the stylistic choices I've made. The new function feels solid to me (except for some missing error checking), but the call sequence at the bottom seems kind of ugly.