qemu: fix guest agent patch #25780
Open
qemu: fix guest agent patch #25780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace to fix openwrt#25209 Signed-off-by: Vladimir Ermakov <[email protected]>
|
Tested and works fine. However, the commit message should be changed, because it doesn't actually fix #25209 (it is already fixed by QEMU 9.1.2). As mentioned in a comment on the linked issue, it does fix another bug in the shutdown script. |
janh
reviewed
Jan 24, 2025
Comment on lines
+4
to
+5
| diff --git a/qga/commands-posix.c b/qga/commands-posix.c | ||
| index c2bd0b4316..f6dfa20c1f 100644 |
There was a problem hiding this comment.
This seems to be what causes the checks to fail (in make package/qemu/refresh).
Do you plan to fix this and update the commit message? Otherwise I'll just create a similar pull request myself.
There was a problem hiding this comment.
Please go ahead. Don't have bandwidth this weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @yousong
Compile tested: x86_64, OpenWrt master
Run tested: x86_64 host, KVM for qemu-x86_64-softmmu + Bios VM.
Description: