ddns-scripts: Fixup huaweicloud #26053
Open
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script will exit when an error occurred. Signed-off-by: Lehua Zhang <[email protected]>
feckert
requested changes
Feb 26, 2025
| @@ -149,4 +155,4 @@ if [ $ret -eq 1 ]; then | |||
| fi | |||
| if [ $ret -eq 2 ]; then | |||
| upd_record | |||
| fi | |||
| fi | |||
| @@ -85,16 +85,18 @@ hcloud_transfer() { | |||
| "https://$reqUrl" | |||
|
|
|||
| if [ $? -ne 0 ]; then | |||
| write_log 14 "rest api error" | |||
| write_log 4 "rest api error" | |||
There was a problem hiding this comment.
Can you also add to your commit message why you have changed the log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @feckert
Compile tested: RAX300M
Run tested: RAX300M
Description:
Script will exit when an error occurred.