Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip channel program tests on Apple Silicon #17053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcd1193182
Copy link
Contributor

Motivation and Context

I have a small VM set up on my macbook to do some basic testing with. Unfortunately, the channel program tests consistently cause me problems. The issue appears to be that there is something wrong with our lua interpreter when running on apple silicon.

Description

This PR simply skips the channel program tests if it detects that it's running on Apple Silicon.

How Has This Been Tested?

Ran the test suite on my macbook and on a normal linux VM.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I would make a is_linux_apple_silicon or similar to not have to repeat it. On the other hand, this is a temporary situation, so maybe making a proper function gives a suggestion of permanence that we don't want to encourage :)

@@ -18,4 +18,10 @@

DISK=${DISKS%% *}

if [[ "$(uname -m)" == "aarch64" ]] && is_linux ; then
if awk '/^CPU implementer/ {exit !/0x61/}' /proc/cpuinfo; then
log_unsupported "Not supported on Apple Silicon"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably wouldn't hurt to be specific:
"Not supported on Linux VMs running on Apple ARM silicon"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the tests may also not work on FreeBSD, but I wasn't sure how to check if a VM is running on Apple SIlicon on FreeBSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants