Allow lockless zpool status #17305
Open
Allow lockless zpool status #17305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Add a new `ZPOOL_LOCK_BEHAVIOR` envvar to control `zpool status` lock behavior. `ZPOOL_LOCK_BEHAVIOR` can have one of these values: "lockless": Try for a short amount of time to get the spa_namespace lock. If that doesn't work, then do the zpool status locklessly. This is dangerous and can crash your system if the pools configs are being modified while zpool status is running. This setting requires `zpool status` to be run as root. "trylock": Try for a short amount of time to get the spa_namespace lock. If that doesn't work then simply abort 'zpool status'. "wait": Wait forever for the lock. This is the default. These options allow users to view the zpool status when the pool gets stuck while holding the spa_namespace lock. Signed-off-by: Tony Hutter <[email protected]>
Signed-off-by: Tony Hutter <[email protected]>
tonyhutter
force-pushed
the
disable_locks4
branch
from
4412348 to
323d304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Allow
zpool statusto work even when the pool is locked up. This is a reworked version of #17193 that uses an environment variable instead of command line flags.Description
Add a new
ZPOOL_LOCK_BEHAVIORenvvar to controlzpool statuslock behavior.ZPOOL_LOCK_BEHAVIORcan have one of these values:lockless: Try for a short amount of time to get the spa_namespace lock. If that doesn't work, then do thezpool statuslocklessly. This is dangerous and can crash your system if the pools configs are being modified whilezpool statusis running. This setting requireszpool statusto be run as root.trylock: Try for a short amount of time to get the spa_namespace lock. If that doesn't work then simply abortzpool status.wait: Wait forever for the lock. This is the default.These options allow users to view the
zpool statuswhen the pool gets stuck while holding the spa_namespace lock.How Has This Been Tested?
Added test case
Types of changes
Checklist:
Signed-off-by.