Update pam_zfs_key.c default path for FreeBSD #17600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be somehow configured instead of the hardcoded path? |
It is configurable with the |
amotin
approved these changes
Aug 7, 2025
behlendorf
approved these changes
Aug 7, 2025
behlendorf
added
Status: Accepted
|
@eborisch please update the commit message with your signed-off-by, then this should be all set. https://github.com/openzfs/zfs/actions/runs/16793233992/job/47558772845?pr=17600 |
behlendorf
added
the
Status: Revision Needed
|
@eborisch can you add your signed off by to the commit and update this PR. If not, we'll have to close it out. |
As described in freebsd/freebsd-src#1305 : FreeBSD's installer defaults to zroot/home for user home directories. For FreeBSD only, set the default prefix for pam_zfs_key to match. Signed-off-by: Eric A. Borisch <[email protected]>
eborisch
force-pushed
the
pam_zfs_key-default-home
branch
from
72c2c03 to
b453d9f
Compare
github-actions
bot
removed
Status: Accepted
|
Done. Apologies for the delay. |
spauka
pushed a commit
to spauka/zfs
that referenced
this pull request
Aug 30, 2025
As described in freebsd/freebsd-src#1305, FreeBSD's installer defaults to zroot/home for user home directories. For FreeBSD only, set the default prefix for pam_zfs_key to match. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Eric A. Borisch <[email protected]> Closes openzfs#17600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in freebsd/freebsd-src#1305 : FreeBSD's installer defaults to zroot/home for user home directories.
For FreeBSD only, set the default prefix for pam_zfs_key to match.
Motivation and Context
This will resolve freebsd/freebsd-src#1305 : have the default for pam_zfs_key's home directory root match what FreeBSD installer sets it to.
Description
FreeBSD-only (ifdef-ed) change of the default (in the zfs tree) home location for pam_zfs_key.
How Has This Been Tested?
No testing of this minor change. pam_zfs_key isn't quite "ready for prime time" (IMHO) on FreeBSD, but this is one step towards that.
Types of changes
Checklist:
Signed-off-by.