deps: reverts to zipkin-reporter 2.x #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After integrating with Sleuth and Otel, it seems hastey to manage the zipkin-reporter to 3.0. The reason is both projects end up sharing classpath between Brave and reporter types. Since Brave doesn't care about this version anyway, it can leave it at the prior and remove tension. Brave 6 will completely remove zipkin version management, anyway. Following this change, I will cut a release-5.18.1 tag. Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Jan 8, 2024
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| <!-- use the same values in ../pom.xml --> | |||
| <zipkin.version>2.27.0</zipkin.version> | |||
| <zipkin-reporter.version>3.0.0</zipkin-reporter.version> | |||
| <zipkin-reporter.version>2.17.2</zipkin-reporter.version> | |||
There was a problem hiding this comment.
this is the main change. the license thing was that reverting files touches them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After integrating with Sleuth and Otel, it seems hastey to manage the zipkin-reporter to 3.0. The reason is both projects end up sharing classpath between Brave and reporter types. Since Brave doesn't care about this version anyway, it can leave it at the prior and remove tension. Brave 6 will completely remove zipkin version management, anyway.
Following this change, I will cut a release-5.18.1 tag, then restore the Brave 6 commit (44e4081) and release it.