Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: updates all dependencies, notably Kafka #1419

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

codefromthecrypt
Copy link
Member

This updates all the versions we can prior to the patch release 6.0.2

@@ -254,6 +255,11 @@ public Map<TopicPartition, OffsetAndMetadata> committed(
return delegate.committed(partitions, timeout);
}

// Do not use @Override annotation to avoid compatibility issue version < 3.7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how we address new functions added, while still supporting running with older versions

@@ -42,6 +42,7 @@
import org.apache.kafka.common.MetricName;
import org.apache.kafka.common.PartitionInfo;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.Uuid;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully this type is available in old versions ;) invoker tests will find out

@codefromthecrypt
Copy link
Member Author

Here's the new trivy. Most of it is due to spring stuff. spring-rabbit is highly neglected and stuck until someone helps with its internal drift (reflection-fu)

$ trivy repo --skip-dirs "**/src/it,**/target"  .
2024-02-27T15:24:27.173+0800	INFO	Vulnerability scanning is enabled
2024-02-27T15:24:27.173+0800	INFO	Secret scanning is enabled
2024-02-27T15:24:27.173+0800	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-02-27T15:24:27.173+0800	INFO	Please see also https://aquasecurity.github.io/trivy/v0.48/docs/scanner/secret/#recommendation for faster secret detection
2024-02-27T15:26:44.214+0800	INFO	Number of language-specific files: 41
2024-02-27T15:26:44.214+0800	INFO	Detecting pom vulnerabilities...

instrumentation/benchmarks/pom.xml (pom)

Total: 6 (UNKNOWN: 0, LOW: 0, MEDIUM: 5, HIGH: 0, CRITICAL: 1)

┌──────────────────────────────────────┬──────────────────┬──────────┬──────────┬───────────────────┬────────────────────────┬──────────────────────────────────────────────────────────────┐
│               Library                │  Vulnerability   │ Severity │  Status  │ Installed Version │     Fixed Version      │                            Title                             │
├──────────────────────────────────────┼──────────────────┼──────────┼──────────┼───────────────────┼────────────────────────┼──────────────────────────────────────────────────────────────┤
│ com.rabbitmq:amqp-client             │ CVE-2023-46120   │ MEDIUM   │ fixed    │ 5.9.0             │ 5.18.0                 │ RabbitMQ Java client's Lack of Message Size Limitation leads │
│                                      │                  │          │          │                   │                        │ to Remote DoS...                                             │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2023-46120                   │
├──────────────────────────────────────┼──────────────────┤          ├──────────┼───────────────────┼────────────────────────┼──────────────────────────────────────────────────────────────┤
│ org.jboss.resteasy:resteasy-undertow │ CVE-2023-0482    │          │ affected │ 3.15.6.Final      │                        │ RESTEasy: creation of insecure temp files                    │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2023-0482                    │
├──────────────────────────────────────┼──────────────────┤          ├──────────┼───────────────────┼────────────────────────┼──────────────────────────────────────────────────────────────┤
│ org.springframework.amqp:spring-amqp │ CVE-2021-22095   │          │ fixed    │ 2.3.6             │ 2.2.19, 2.3.11         │ Deserialization of Untrusted Data in Spring AMQP             │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2021-22095                   │
│                                      ├──────────────────┤          │          │                   │                        ├──────────────────────────────────────────────────────────────┤
│                                      │ CVE-2021-22097   │          │          │                   │                        │ Deserialization of Untrusted Data in Spring AMQP             │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2021-22097                   │
├──────────────────────────────────────┼──────────────────┤          │          ├───────────────────┼────────────────────────┼──────────────────────────────────────────────────────────────┤
│ org.springframework:spring-messaging │ CVE-2022-22971   │          │          │ 5.3.5             │ 5.3.20, 5.2.22.RELEASE │ DoS with STOMP over WebSocket                                │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2022-22971                   │
├──────────────────────────────────────┼──────────────────┼──────────┤          ├───────────────────┼────────────────────────┼──────────────────────────────────────────────────────────────┤
│ org.springframework:spring-web       │ CVE-2016-1000027 │ CRITICAL │          │ 5.3.32            │ 6.0.0                  │ spring: HttpInvokerServiceExporter readRemoteInvocation      │
│                                      │                  │          │          │                   │                        │ method untrusted java deserialization                        │
│                                      │                  │          │          │                   │                        │ https://avd.aquasec.com/nvd/cve-2016-1000027                 │
└──────────────────────────────────────┴──────────────────┴──────────┴──────────┴───────────────────┴────────────────────────┴──────────────────────────────────────────────────────────────┘

@codefromthecrypt
Copy link
Member Author

note anyone who tests old versions will forever need to add config to their repo to do --skip-dirs "**/src/it,**/target" until there's a scanner who treats this more specifically. I tried and failed to convince trivy oh well!

@codefromthecrypt codefromthecrypt merged commit 7dcd132 into master Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant