Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: moves dependency scope to test except wire #3756

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

codefromthecrypt
Copy link
Member

same as openzipkin/brave#1422 except...

  • some glitches result in wire (proto) being a main dep.
    • this isn't an issue for CVEs because it is updated frequently.
  • a little build of build dep work to remove logger conflicts
    • most are aware of the dancing here, due to zipkin-server using two different log setups

ran server benchmarks just to make sure:

2024-04-12 13:47:32:209 [testcontainers-lifecycle-1] WARN tc.quay.io/dim/wrk:stable - The architecture 'amd64' for image 'quay.io/dim/wrk:stable' (ID sha256:11fb87b1ef9581f3a443395ab0080842170e66f195a1f63cfbc15b83822b2af6) does not match the Docker server architecture 'arm64'. This will cause the container to execute much more slowly due to emulation and may lead to timeout failures.
Benchmark started.
Container ghcr.io/openzipkin/java:21.0.2_p13 ports exposed at {9411=http://192.168.106.2:32932}
Container ghcr.io/openzipkin/zipkin-elasticsearch7:3.1.1 ports exposed at {9200=http://192.168.106.2:32927}
Container ghcr.io/openzipkin/brave-example:armeria ports exposed at {9000=http://192.168.106.2:32928}
Container ghcr.io/openzipkin/brave-example:armeria ports exposed at {8081=http://192.168.106.2:32931}
Container quay.io/prometheus/prometheus:v2.48.0 ports exposed at {9090=http://192.168.106.2:32930}
Container quay.io/giantswarm/grafana:7.5.4 ports exposed at {3000=http://192.168.106.2:32929}
--snip--

@codefromthecrypt
Copy link
Member Author

trivy repo . --scanners vuln doesn't show benchmarks in it

@codefromthecrypt
Copy link
Member Author

lint is broken due to this: #3757

@codefromthecrypt codefromthecrypt merged commit 845312a into master Apr 13, 2024
13 checks passed
@codefromthecrypt codefromthecrypt deleted the benchmarks-test branch April 13, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant