fix: retry finalizer removal on http 422 #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can happen if there are multiple finalizers present and multiple reconilers competent to remove their finalizer, since we remove the finalizer with JSON Patch Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
see: #2759 (comment) |
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Attila Mészáros <[email protected]>
|
cc @tomdw , checking the logs in the integration test I was able to confirm that indeed this happens with 422. Thank you for reporting. |
csviri
changed the title
xstefank
approved these changes
Apr 30, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Apr 30, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Stefanko <[email protected]>
metacosm
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can happen if there are multiple finalizers present and multiple reconilers competent to remove their finalizer, since we remove the finalizer with JSON Patch
Signed-off-by: Attila Mészáros [email protected]