fix Members::SetAttributesService role setting specs

spec/services/members/set_attributes_service_spec.rb

@@ -109,14 +109,12 @@
 
       context 'with a persisted record' do
         let(:member) do
-          build_stubbed(:member, roles: [first_role, second_role]).tap do |m|
-            allow(m)
-              .to receive(:touch)
-          end
+          build_stubbed(:member, roles: [first_role, second_role])
         end
 
-        it 'adds the new role' do
-          expect(subject.result.roles = [second_role, third_role])
+        it 'adds the new role and marks the other for destruction' do
+          expect(subject.result.member_roles.map(&:role_id)).to contain_exactly(first_role.id, second_role.id, third_role.id)
+          expect(subject.result.member_roles.detect { _1.role_id == first_role.id }).to be_marked_for_destruction
         end
       end
 
@@ -126,7 +124,7 @@
         end
 
         it 'adds the new role' do
-          expect(subject.result.roles = [second_role, third_role])
+          expect(subject.result.member_roles.map(&:role_id)).to contain_exactly(second_role.id, third_role.id)
         end
 
         context 'with role_ids not all being present' do
@@ -137,7 +135,7 @@
           end
 
           it 'ignores the empty values' do
-            expect(subject.result.roles = [second_role, third_role])
+            expect(subject.result.member_roles.map(&:role_id)).to contain_exactly(second_role.id, third_role.id)
           end
         end
       end

spec/services/work_package_members/set_attributes_service_spec.rb

@@ -156,10 +156,7 @@
 
       context 'with a persisted record' do
         let(:member) do
-          build_stubbed(:work_package_member, roles: [first_role, second_role]) do |m|
-            allow(m)
-              .to receive(:touch)
-          end
+          build_stubbed(:work_package_member, roles: [first_role, second_role])
         end
 
         it 'adds the new role and marks the other for destruction' do