[59539] Make work packages manually scheduled by default

The `schedule_manually` column is also non-nullable now.

This includes the following changes:

- Automatically scheduled parent dates are and `ignore_non_working_days`
  attributes are now always derived from children's values, even if the
  children are scheduled manually.

  It's more natural. Without that, adding a child to a work package
  would not change the parent's dates.

  As a consequence, the parent can start on a non-working day if one of
  its children is manually scheduled, ignores non-working days, and
  starts on a non-working day. That's why the parent's
  `ignore_non_working_days` attribute is now also derived from all its
  children regardless of the scheduling mode.

  If the parent is manually scheduled, its dates and it's ability to
  ignore non-working days will still be defined independently from its
  children.

- Fix tests broken by scheduling mode being manual by default.

  The tests had to be adapted to explicitly set scheduling mode to
  automatic for followers and parents, and sometimes even follower's
  children. Without it, work packages would not be rescheduled
  automatically.

- Replace schedule helpers with table helpers.

  Schedule helpers helped well, but table helpers are more flexible and
  support more column types.

- Add "days counting" and "scheduling mode" columns to table helpers.

  "days counting" to set `ignore_non_working_days` attribute.
    - "all days" value maps to `ignore_non_working_days: true`.
    - "working days" value maps to `ignore_non_working_days: false`.
  "scheduling mode" to set `schedule_manually` attribute.
    - "manual" value maps to `schedule_manually: true`.
    - "automatic" value maps to `schedule_manually: false`.

app/models/work_packages/scopes/for_scheduling.rb

@@ -51,6 +51,11 @@ module ForScheduling
       # statement works, is that a work package is considered to be scheduled
       # manually if *all* of its descendants are scheduled manually.
       #
+      # One notable exception is if one of the manually scheduled children is
+      # the origin work package of the rescheduling. In this case, the parent is
+      # also subject to reschedule as the origin work package dates may have
+      # changed.
+      #
       # For example in case of the hierarchy:
       #   A and B <- hierarchy (C is parent of both A and B) - C <- hierarchy - D
       # * A and B are work packages
@@ -157,21 +162,25 @@ def for_scheduling(work_packages)
       def scheduling_paths_sql(work_packages)
         values = work_packages.map do |wp|
           ::OpenProject::SqlSanitization
-            .sanitize "(:id, false, false)",
+            .sanitize "(:id, false, false, true)",
                       id: wp.id
         end.join(", ")
 
         <<~SQL.squish
-          to_schedule (id, manually) AS (
+          to_schedule (id, manually, hierarchy_up, origin) AS (
 
-            SELECT * FROM (VALUES#{values}) AS t(id, manually, hierarchy_up)
+            SELECT * FROM (VALUES#{values}) AS t(id, manually, hierarchy_up, origin)
 
             UNION
 
             SELECT
               relations.from_id id,
-              (related_work_packages.schedule_manually OR COALESCE(descendants.manually, false)) manually,
-              relations.hierarchy_up
+              (related_work_packages.schedule_manually
+                OR (COALESCE(descendants.manually, false)
+                    AND NOT (to_schedule.origin AND relations.hierarchy_up))
+              ) manually,
+              relations.hierarchy_up,
+              false origin
             FROM
               to_schedule
             JOIN LATERAL
@@ -196,7 +205,7 @@ def scheduling_paths_sql(work_packages)
                 FROM
                   work_package_hierarchies
                 WHERE
-                  NOT to_schedule.manually
+                  (NOT to_schedule.manually OR to_schedule.origin)
                   AND ((work_package_hierarchies.ancestor_id = to_schedule.id AND NOT to_schedule.hierarchy_up AND work_package_hierarchies.generations = 1)
                        OR (work_package_hierarchies.descendant_id = to_schedule.id AND work_package_hierarchies.generations > 0))
               ) relations ON relations.to_id = to_schedule.id

app/services/work_packages/update_ancestors_service.rb

@@ -209,9 +209,7 @@ def modified_attributes_justify_derivation?(attributes)
   end
 
   def ignore_non_working_days_of_descendants(ancestor, loader)
-    children = loader
-                 .children_of(ancestor)
-                 .reject(&:schedule_manually)
+    children = loader.children_of(ancestor)
 
     if children.any?
       children.any?(&:ignore_non_working_days)

db/migrate/20241120095318_update_scheduling_mode_and_lags.rb

@@ -1,10 +1,20 @@
 class UpdateSchedulingModeAndLags < ActiveRecord::Migration[7.1]
   def up
+    change_column_default :work_packages, :schedule_manually, from: false, to: true
+    execute "UPDATE work_packages SET schedule_manually = false WHERE schedule_manually IS NULL"
+    change_column_null :work_packages, :schedule_manually, false
+
     migration_job = WorkPackages::AutomaticMode::MigrateValuesJob
     if Rails.env.development?
       migration_job.perform_now
     else
       migration_job.perform_later
     end
   end
+
+  def down
+    change_column_default :work_packages, :schedule_manually, from: true, to: false
+    # Keep the not-null constraint when rolling back
+    change_column_null :work_packages, :schedule_manually, false
+  end
 end

modules/team_planner/spec/features/team_planner_remove_event_spec.rb

@@ -60,6 +60,7 @@
            project:,
            subject: "Parent work package",
            assigned_to: other_user,
+           schedule_manually: false, # because parent of child_wp
            start_date: Time.zone.today.beginning_of_week.next_occurring(:wednesday),
            due_date: Time.zone.today.beginning_of_week.next_occurring(:thursday),
            derived_start_date: Time.zone.today.beginning_of_week.next_occurring(:wednesday),

modules/team_planner/spec/features/team_planner_user_interaction_spec.rb

@@ -29,7 +29,7 @@
 require "spec_helper"
 require_relative "shared_context"
 
-RSpec.describe "Team planner drag&dop and resizing",
+RSpec.describe "Team planner drag&drop and resizing",
                :js,
                with_ee: %i[team_planner_view],
                with_settings: { start_of_week: 1 } do
@@ -45,6 +45,7 @@
     create(:work_package,
            project:,
            assigned_to: other_user,
+           schedule_manually: false, # because parent of second_wp
            start_date: Time.zone.today.beginning_of_week.next_occurring(:tuesday),
            due_date: Time.zone.today.beginning_of_week.next_occurring(:thursday))
   end

spec/controllers/work_packages/bulk_controller_spec.rb

@@ -565,7 +565,7 @@
       end
 
       let(:new_parent) do
-        create(:work_package, project: project1)
+        create(:work_package, schedule_manually: false, project: project1)
       end
 
       before do

spec/features/admin/working_days_spec.rb

@@ -34,12 +34,12 @@
   shared_let(:week_days) { week_with_saturday_and_sunday_as_weekend }
   shared_let(:admin) { create(:admin) }
 
-  let_schedule(<<~CHART)
-    days                  | MTWTFSSmtwtfss |
-    earliest_work_package | XXXXX          |
-    second_work_package   |    XX..XX      |
-    follower              |          XXX   | follows earliest_work_package, follows second_work_package
-  CHART
+  let_work_packages(<<~TABLE)
+    subject               | MTWTFSSmtwtfss | scheduling mode | properties
+    earliest_work_package | XXXXX          | manual          |
+    second_work_package   |    XX..XX      | manual          |
+    follower              |          XXX   | automatic       | follows earliest_work_package, follows second_work_package
+  TABLE
 
   let(:dialog) { Components::ConfirmationDialog.new }
   let(:datepicker) { Components::DatepickerModal.new }
@@ -48,6 +48,8 @@
 
   before do
     visit admin_settings_working_days_and_hours_path
+    # wait for "holidays and closures" calendar to load
+    find(".fc-next-button")
   end
 
   describe "week days" do
@@ -81,12 +83,12 @@ def working_days_setting
 
       expect(working_days_setting).to eq([1, 2, 3, 4, 5])
 
-      expect_schedule(WorkPackage.all, <<~CHART)
-        days                  | MTWTFSSmtwtfss |
+      expect_work_packages(WorkPackage.all, <<~TABLE)
+        subject               | MTWTFSSmtwtfss |
         earliest_work_package | XXXXX          |
         second_work_package   |    XX..XX      |
         follower              |          XXX   |
-      CHART
+      TABLE
     end
 
     it "updates the values and saves the settings" do
@@ -112,12 +114,12 @@ def working_days_setting
 
       expect(working_days_setting).to eq([2, 3, 4])
 
-      expect_schedule(WorkPackage.all, <<~CHART)
-        days                  | MTWTFSSmtwtfssmtwt  |
+      expect_work_packages(WorkPackage.all, <<~TABLE)
+        subject               | MTWTFSSmtwtfssmtwt  |
         earliest_work_package |  XXX....XX          |
         second_work_package   |    X....XXX         |
         follower              |                XXX  |
-      CHART
+      TABLE
 
       # The updated work packages will have a journal entry informing about the change
       wp_page = Pages::FullWorkPackage.new(earliest_work_package)
@@ -152,12 +154,12 @@ def working_days_setting
       expect(page).to have_unchecked_field "Sunday"
       expect(working_days_setting).to eq([1, 2, 3, 4, 5])
 
-      expect_schedule(WorkPackage.all, <<~CHART)
-        days                  | MTWTFSSmtwtfss |
+      expect_work_packages(WorkPackage.all, <<~TABLE)
+        subject               | MTWTFSSmtwtfss |
         earliest_work_package | XXXXX          |
         second_work_package   |    XX..XX      |
         follower              |          XXX   |
-      CHART
+      TABLE
     end
 
     it "shows an error when a previous change to the working days configuration isn't processed yet" do

spec/features/work_packages/datepicker/datepicker_follows_relation_spec.rb

@@ -80,15 +80,15 @@
   end
 
   context "if the follower is a task" do
-    let!(:follower) { create(:work_package, type:, project:) }
+    let!(:follower) { create(:work_package, type:, project:, schedule_manually: false) }
     let!(:relation) { create(:follows_relation, from: follower, to: predecessor) }
     let(:date_field) { work_packages_page.edit_field(:combinedDate) }
 
     it_behaves_like "keeps the minimum date from the predecessor when toggling NWD"
   end
 
   context "if the follower is a milestone" do
-    let!(:follower) { create(:work_package, type: milestone_type, project:) }
+    let!(:follower) { create(:work_package, type: milestone_type, project:, schedule_manually: false) }
     let!(:relation) { create(:follows_relation, from: follower, to: predecessor) }
     let(:date_field) { work_packages_page.edit_field(:date) }
 

spec/features/work_packages/datepicker/datepicker_parent_spec.rb

@@ -62,7 +62,7 @@
     datepicker.expect_visible
   end
 
-  context "with the child having set dates" do
+  context "with the child having set dates and the parent being scheduled automatically" do
     let(:child_attributes) do
       {
         start_date: "2021-02-01",
@@ -71,17 +71,46 @@
       }
     end
 
-    it "disables the non working days options" do
-      datepicker.expect_ignore_non_working_days_disabled
-      datepicker.expect_scheduling_mode false
+    context "when the parent is scheduled automatically" do
+      let(:parent_attributes) do
+        {
+          schedule_manually: false
+        }
+      end
 
-      first_monday = Time.zone.today.beginning_of_month.next_occurring(:monday)
-      datepicker.expect_disabled(first_monday)
+      it "disables the non-working days options" do
+        datepicker.expect_ignore_non_working_days_disabled
+        datepicker.expect_automatic_scheduling_mode
 
-      datepicker.toggle_scheduling_mode
-      datepicker.expect_scheduling_mode true
+        first_monday = Time.zone.today.beginning_of_month.next_occurring(:monday)
+        datepicker.expect_disabled(first_monday)
 
-      datepicker.expect_not_disabled(first_monday)
+        datepicker.toggle_scheduling_mode
+        datepicker.expect_manual_scheduling_mode
+
+        datepicker.expect_not_disabled(first_monday)
+      end
+    end
+
+    context "when the parent is scheduled manually" do
+      let(:parent_attributes) do
+        {
+          schedule_manually: true
+        }
+      end
+
+      it "enables the non-working days options" do
+        datepicker.expect_ignore_non_working_days_enabled
+        datepicker.expect_manual_scheduling_mode
+
+        first_monday = Time.zone.today.beginning_of_month.next_occurring(:monday)
+        datepicker.expect_not_disabled(first_monday)
+
+        datepicker.toggle_scheduling_mode
+        datepicker.expect_automatic_scheduling_mode
+
+        datepicker.expect_disabled(first_monday)
+      end
     end
   end
 end

spec/features/work_packages/scheduling/scheduling_mode_spec.rb

@@ -52,19 +52,22 @@
   let!(:wp) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because parent of wp_child and follows wp_pre
            start_date: Date.parse("2016-01-01"),
            due_date: Date.parse("2016-01-05"),
            parent: wp_parent)
   end
   let!(:wp_parent) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because parent of wp
            start_date: Date.parse("2016-01-01"),
            due_date: Date.parse("2016-01-05"))
   end
   let!(:wp_child) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because needed to have rescheduling working
            start_date: Date.parse("2016-01-01"),
            due_date: Date.parse("2016-01-05"),
            parent: wp)
@@ -80,6 +83,7 @@
   let!(:wp_suc) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because parent of wp_suc_child and follows wp
            start_date: Date.parse("2016-01-06"),
            due_date: Date.parse("2016-01-10"),
            parent: wp_suc_parent).tap do |suc|
@@ -89,12 +93,14 @@
   let!(:wp_suc_parent) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because parent of wp_suc
            start_date: Date.parse("2016-01-06"),
            due_date: Date.parse("2016-01-10"))
   end
   let!(:wp_suc_child) do
     create(:work_package,
            project:,
+           schedule_manually: false, # because needed to have rescheduling working
            start_date: Date.parse("2016-01-06"),
            due_date: Date.parse("2016-01-10"),
            parent: wp_suc)

spec/features/work_packages/table/scheduling/manual_scheduling_spec.rb

@@ -10,7 +10,8 @@
     create(:work_package,
            project:,
            type:,
-           subject: "Parent")
+           subject: "Parent",
+           schedule_manually: false)
   end
 
   let!(:child) do
@@ -117,8 +118,4 @@
       expect(parent.due_date.iso8601).to eq("2020-07-25")
     end
   end
-
-  context "with a user allowed to view only" do
-    let(:role) { create(:project_role, permissions: %i[view_work_packages]) }
-  end
 end

spec/lib/api/v3/work_packages/schema/specific_work_package_schema_spec.rb

@@ -213,6 +213,10 @@
         end
 
         context "when scheduled automatically" do
+          before do
+            work_package.schedule_manually = false
+          end
+
           it "is not writable" do
             expect(subject).not_to be_writable(:start_date)
           end
@@ -246,6 +250,10 @@
         end
 
         context "when scheduled automatically" do
+          before do
+            work_package.schedule_manually = false
+          end
+
           it "is not writable" do
             expect(subject).not_to be_writable(:due_date)
           end
@@ -277,11 +285,18 @@
         allow(work_package.type).to receive(:is_milestone?).and_return(true)
       end
 
-      it "is not writable when the work package is a parent" do
+      it "is not writable when the work package is a parent scheduled automatically" do
         allow(work_package).to receive(:leaf?).and_return(false)
+        work_package.schedule_manually = false
         expect(subject).not_to be_writable(:date)
       end
 
+      it "is writable when the work package is a parent scheduled manually" do
+        allow(work_package).to receive(:leaf?).and_return(false)
+        work_package.schedule_manually = true
+        expect(subject).to be_writable(:date)
+      end
+
       it "is writable when the work package is a leaf" do
         allow(work_package).to receive(:leaf?).and_return(true)
         expect(subject).to be_writable(:date)