Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring meetings #15620

Draft
wants to merge 114 commits into
base: dev
Choose a base branch
from
Draft

Recurring meetings #15620

wants to merge 114 commits into from

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented May 21, 2024

Implementation chunks

https://community.openproject.org/work_packages/54188

  • https://community.openproject.org/work_packages/58225
    • The meeting agenda page is one level lower than the regular meeting agenda page:
    • The breadcrumb will be "{Project name} / Meetings / {Meeting series name} / Date"
    • The title will be: "{Date} ({Series name})" (with the series name in parentheses in a lighter shade)
    • The title will not be editable
    • The description in the PageHeader will be: "This meeting is part of a recurring meeting series. Last updated {last-updated-time}".
    • The Meeting details pane on the left has one extra line at the top: Icon: recurring icon ("iterations"), Link with title of the Meeting series: clicking on this takes the user to the Meeting series index

Known TODOS

  • Recurring meetings index/show does not always use correct layout/sidebar
  • Output schedule from new fields on recurring
  • Merge schedule with known instantiated meetings
  • Use CopyService with recurring_meeting_id to instantiate a meeting using a given schedule item/specific date
  • Clarify labels vs state component
  • Editing of templates requires combined form of series and meeting template
  • Remove current recurring filter, add boolean one
  • Add direction toggle to the meetings index page for recurring meetings
  • Automatically scheduling the next meeting occurrence
  • Use format_date everywhere
  • Update show page button and actions
  • Check/fix copy behaviour of an occurrence
  • Add new table/join to handle cancelling
  • Check/fix delete behaviour
  • Check/fix updating end date/count after a meeting is already instantiated
  • Change default frequency to weekly
  • Show rescheduled meetings
  • Update cancel behaviour
  • Recreate job when the series is updated
  • Deal with the default meetings order

Known TODOS in separate PRs

  • Cancellation dialog
  • ICS
  • Fixed URL
  • Update template blansklate so it's clear first occurrence is not yet instantiated
  • Create button in template to "finish setup"

Issues found

  • End date can be before start date for form submission
  • Date validation is broken
  • Deleting a recurring meeting leads to a meetings index page without the subheader
  • End date is not respected for scheduled list (always at least 5, from the count set in the controller?)
  • End date field shown in edit form when end after is no. of occurrences when first opened
  • Dates in the recurring occurrences list do not match other date formats (header + regular meetings table)
  • Details dialog cannot be opened for meetings
  • (Maybe unrelated) Default location in the dialog form is "1.0"
  • Can't save changes via the meeting details dialog (date/time)
  • Changing the schedule keeps cancelled meetings, even if they are no longer on scheduled dates (delete?)
  • End date cannot be changed to an earlier one
  • Regular meeting delete is broken
  • Rescheduling an occurrence to a past date still shows it in the upcoming list
  • Cancelled meetings stay in the past list

Questions

https://community.openproject.org/projects/meetings-stream/meetings/3901

@oliverguenther oliverguenther force-pushed the feature/recurring-meetings branch 2 times, most recently from 4a85acc to df1adef Compare October 2, 2024 19:25
@oliverguenther oliverguenther changed the title Prepare basic recurring meeting setup Recurring meetings Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants