-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[58454] Sidebar menu should be hidden when page width is reduced #17003
[58454] Sidebar menu should be hidden when page width is reduced #17003
Conversation
d423245
to
6a074fe
Compare
fb183c8
to
8005f9e
Compare
8005f9e
to
b7657c3
Compare
Hi @bsatarnejad I have one remark, the sidemenu is not showing up after the browser width was reduced and then increased. I believe the sidemenu should show up according to the specification.
|
Hi @dombesz thanks, It's good point to fix this issue too. 👍 |
aabfedd
to
b210c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bsatarnejad , the resizing now works correctly. However, if the sidebar is hidden, it will still reappear after a refresh of the page.
Thank you for sharing your feedback! The behavior you're seeing is actually the default for the sidebar menu, so this particular fix doesn't address the issue you've pointed out. |
9938a46
to
c36f13c
Compare
b567586
to
035d90c
Compare
f8d7e5e
to
f056f69
Compare
f056f69
to
7de4100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bsatarnejad , LGTM! 👍
Ticket
https://community.openproject.org/wp/58454
What are you trying to accomplish?
While resizing the window, if the window size is small, hide the menu like when we reload the page.
Screenshots
Before:
https://github.com/user-attachments/assets/7fae43a9-0505-4f8d-9ef5-bff49760d4f3
After:
https://github.com/user-attachments/assets/7da06ace-4a34-4592-9364-195f07d2f184
What approach did you choose and why?
Hide the side menu while resizing if the window size is smaller than 1012px.
Merge checklist