Fix code comment for frontend ports #17333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was most likely a copy & paste mistake.
Looking at this, I am still wondering whether more guidance would be useful on when to use which port to access the application. The comments in the
docker-compose.override.example.yml
merely state the obvious ("these things are port mappings"). But if I am asking myself whether I should access the app via port 3000 or 4200, I am lost.Elsewhere I can find:
So there seems to be no big difference between the two? However, @mereghost wrote me in a DM:
So my take is, that for anything where I access the UI, 4200 is preferable?
Merge checklist
Added/updated testsAdded/updated documentation in Lookbook (patterns, previews, etc)Tested major browsers (Chrome, Firefox, Edge, ...)