Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58160] project stage columns on project list #17400

Merged
merged 27 commits into from
Dec 16, 2024

Conversation

EinLama
Copy link
Contributor

@EinLama EinLama commented Dec 9, 2024

Ticket

https://community.openproject.org/wp/58160

What are you trying to accomplish?

All Project::LifeCycleStepDefinition instances show up in the Configure View modal. For each row/project with an active Project::LifeCycleStep configured, its cell will display the date values of the stage or gate fitting that definition.

Please note that as of now, sorting and filtering is not supported for these new columns.

In order to see and test this locally, you must first set up some life cycle step definitions and then populate some projects with the corresponding life cycle steps.

Screenshots

project_list
Above, you can see that life cycle columns are now visible in the project list. They must be active and assigned to any of the projects. Additionally, they must be added via the configure view modal. Only then will they show up. Cells with no active, associated life cycle step are left empty. The appropriate icon and color for the specific definition is displayed.

configure_view
Above, you can see the columns when some life cycle definitions have been added.

quick_action_table_header
Above, you can see the action menu for the new columns. For now, they cannot be used for sorting or filtering. This will be done in later work packages.

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@EinLama EinLama force-pushed the feature/58160-project-stage-columns-on-project-list branch 5 times, most recently from edb3b91 to c9c4269 Compare December 12, 2024 09:28
@EinLama EinLama marked this pull request as ready for review December 12, 2024 09:44
@EinLama EinLama force-pushed the feature/58160-project-stage-columns-on-project-list branch from c9c4269 to adbf595 Compare December 12, 2024 10:02
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works nicely @EinLama !👏
I just left a few notes, but overall it looks good.

@EinLama EinLama force-pushed the feature/58160-project-stage-columns-on-project-list branch from 3880f75 to ce4688e Compare December 13, 2024 09:39
@EinLama EinLama requested a review from dombesz December 13, 2024 09:41
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @EinLama , thank you! 👏
I just made a minor comment on a suggestion on using index_by instead of group_by.

@dombesz dombesz self-requested a review December 13, 2024 13:57
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I just realised that we have to put the whole implementation behind the feature flag :stages_and_gates.
We cannot show the stages and gates as selectable fields in the table configuration, nor show the columns.

@EinLama EinLama force-pushed the feature/58160-project-stage-columns-on-project-list branch 2 times, most recently from a9ee77b to 9eb92df Compare December 16, 2024 08:18
@EinLama
Copy link
Contributor Author

EinLama commented Dec 16, 2024

Thank you for pointing out the necessity for the feature flag. I thought the new columns would be hidden by them being set to inactive by default, but that wasn't true :)

@EinLama EinLama requested a review from dombesz December 16, 2024 08:27
@EinLama EinLama force-pushed the feature/58160-project-stage-columns-on-project-list branch from 9eb92df to 68dc092 Compare December 16, 2024 08:52
Copy link
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @EinLama ! 👏

@EinLama EinLama merged commit a0734ad into dev Dec 16, 2024
11 checks passed
@EinLama EinLama deleted the feature/58160-project-stage-columns-on-project-list branch December 16, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants