-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#58160] project stage columns on project list #17400
[#58160] project stage columns on project list #17400
Conversation
edb3b91
to
c9c4269
Compare
c9c4269
to
adbf595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality works nicely @EinLama !👏
I just left a few notes, but overall it looks good.
3880f75
to
ce4688e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @EinLama , thank you! 👏
I just made a minor comment on a suggestion on using index_by
instead of group_by
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just realised that we have to put the whole implementation behind the feature flag :stages_and_gates
.
We cannot show the stages and gates as selectable fields in the table configuration, nor show the columns.
a9ee77b
to
9eb92df
Compare
Thank you for pointing out the necessity for the feature flag. I thought the new columns would be hidden by them being set to inactive by default, but that wasn't true :) |
This enables us to select a life cycle step as a view. It breaks as soon as you try to render the table including this field type, though.
This is not pretty, but will be removed once #59183 is implemented.
Thanks, Rubocop!
Following the link, firefox now supports this feature.
This also simplifies the sort_helper neatly.
9eb92df
to
68dc092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @EinLama ! 👏
Ticket
https://community.openproject.org/wp/58160
What are you trying to accomplish?
All
Project::LifeCycleStepDefinition
instances show up in the Configure View modal. For each row/project with an activeProject::LifeCycleStep
configured, its cell will display the date values of the stage or gate fitting that definition.Please note that as of now, sorting and filtering is not supported for these new columns.
In order to see and test this locally, you must first set up some life cycle step definitions and then populate some projects with the corresponding life cycle steps.
Screenshots
Above, you can see that life cycle columns are now visible in the project list. They must be active and assigned to any of the projects. Additionally, they must be added via the configure view modal. Only then will they show up. Cells with no active, associated life cycle step are left empty. The appropriate icon and color for the specific definition is displayed.
Above, you can see the columns when some life cycle definitions have been added.
Above, you can see the action menu for the new columns. For now, they cannot be used for sorting or filtering. This will be done in later work packages.
What approach did you choose and why?
Merge checklist