-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose.yml for nextcloud development #17420
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this briliant. It will change lives 🎉
Only thing I believe we should change is the filename from docker-compose.yml
to docker-compose.override.yml
.
The rest are a few observations based on my own setup, but it's okay if they are not included.
@@ -0,0 +1,23 @@ | |||
services: | |||
nextcloud: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to include the cron
override on mine as well
cron:
volumes:
- ${APP_DIR:-./../../custom_apps}:/var/www/html/custom_apps
networks:
- external
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post your full cron
service definition? I only have the nextcloud
service running locally for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to the cron definition in the integration project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Makes sense, if we need cron, we should add it to this compose file. Do you know if cron is needed for our integration purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know. Briefly reading does not sound mandatory. But probably useful to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a cron service as well now. Looking at my local installation, it seems to be working.
I am calling this |
I guess that makes sense. It's not necessarily related to the openproject-nextcloud-integration, is it? I wonder if it would become more confusing in the future. But I see the last steps of the readme are already installing the whole thing. |
This is similar to what we already have for Keycloak and GitLab in providing a minimal docker-compose file for integration work.
549f2ff
to
8a9678b
Compare
This is similar to what we already have for Keycloak and GitLab in providing a minimal docker-compose file for integration work.
Ticket
https://community.openproject.org/projects/document-workflows-stream/work_packages/59937/activity