Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose.yml for nextcloud development #17420

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NobodysNightmare
Copy link
Contributor

This is similar to what we already have for Keycloak and GitLab in providing a minimal docker-compose file for integration work.

Ticket

https://community.openproject.org/projects/document-workflows-stream/work_packages/59937/activity

@NobodysNightmare NobodysNightmare requested a review from a team December 10, 2024 08:37
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this briliant. It will change lives 🎉

Only thing I believe we should change is the filename from docker-compose.yml to docker-compose.override.yml.

The rest are a few observations based on my own setup, but it's okay if they are not included.

@@ -0,0 +1,23 @@
services:
nextcloud:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to include the cron override on mine as well

  cron:
    volumes:
      - ${APP_DIR:-./../../custom_apps}:/var/www/html/custom_apps
    networks:
      - external

Copy link
Contributor Author

@NobodysNightmare NobodysNightmare Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post your full cron service definition? I only have the nextcloud service running locally for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Makes sense, if we need cron, we should add it to this compose file. Do you know if cron is needed for our integration purposes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know. Briefly reading does not sound mandatory. But probably useful to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a cron service as well now. Looking at my local installation, it seems to be working.

docker/dev/nextcloud/docker-compose.yml Show resolved Hide resolved
@NobodysNightmare
Copy link
Contributor Author

I find this briliant. It will change lives 🎉

Only thing I believe we should change is the filename from docker-compose.yml to docker-compose.override.yml.

The rest are a few observations based on my own setup, but it's okay if they are not included.

I am calling this docker-compose.yml because it's not an override file, but a base file. Otherwise: What's the base file we'd be overriding? I would want to avoid providing an override for a file that's not part of this repository, because then the original file could change without us noticing and thus the override would override wrongly.

@brunopagno
Copy link
Contributor

What's the base file we'd be overriding? I would want to avoid providing an override for a file that's not part of this repository, because then the original file could change without us noticing and thus the override would override wrongly.

I guess that makes sense. It's not necessarily related to the openproject-nextcloud-integration, is it? I wonder if it would become more confusing in the future. But I see the last steps of the readme are already installing the whole thing.

This is similar to what we already have for Keycloak and GitLab
in providing a minimal docker-compose file for integration work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants