Make keycloak setup more consistent #17425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving operator control of restart by using unless-stopped. Previously it was in two extremes at the same time: The db would always restart, even if stopped, while the app server would never restart, even if it was running. Also opting into a feature that's necessary to properly configure token exchange according to Keycloak docs at https://www.keycloak.org/securing-apps/token-exchange (While the docs say it's not needed for the internal to internal flow, I literally couldn't follow the instructions without this feature).
NobodysNightmare
force-pushed
the
keycloak-setup
branch
from
8eefde8 to
ed22f53
Compare
Kharonus
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving operator control of restart by using unless-stopped. Previously it was in two extremes at the same time: The db would always restart, even if stopped, while the app server would never restart, even if it was running.
Also opting into a feature that's necessary to properly configure token exchange according to Keycloak docs at https://www.keycloak.org/securing-apps/token-exchange (While the docs say it's not needed for the internal to internal flow, I literally couldn't follow the instructions without this feature).
Ticket
none
What are you trying to accomplish?
Make the default setup for Keycloak more consistent.