Refactor ReplaceReferencesService #17480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
refactor-reference-replacement
branch
from
0957aa1 to
6850b75
Compare
|
@NobodysNightmare Other PR was merged |
Instead of expecting modules to selectively overwrite methods of this class, we offer an explicit extension point where replacements can be registered explicitly. Thus patching the implementation is not necessary anymore, instead it can be configured from initializers.
NobodysNightmare
force-pushed
the
refactor-reference-replacement
branch
from
6850b75 to
4536859
Compare
|
Thanks. Conflicts have been resolved. |
NobodysNightmare
requested review from
machisuji,
oliverguenther,
klaustopher and
akabiru
machisuji
requested changes
Dec 19, 2024
NobodysNightmare
force-pushed
the
refactor-reference-replacement
branch
from
42af851 to
7164635
Compare
There is now add_replacements which accepts a hash, allowing to add multiple replacements in one call. This should make mass-adding replacements look less bulky. Also including helpers to ActsAsOpEngine to make adding replacements from a module nicer.
NobodysNightmare
force-pushed
the
refactor-reference-replacement
branch
from
7164635 to
07a2b14
Compare
NobodysNightmare
requested review from
machisuji
and removed request for
oliverguenther,
klaustopher and
akabiru
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of expecting modules to selectively overwrite methods of this class, we offer an explicit extension point where replacements can be registered explicitly.
Thus patching the implementation is not necessary anymore, instead it can be configured from initializers.
Ticket
none
What are you trying to accomplish?
Avoid the need to overwrite class behaviour from modules.
What approach did you choose and why?
Allowing to configure rewrites, because the implementation is kind of always the same. Thus avoiding to duplicate the implementations. This also works nicer with modules than expecting class overwrites.