Feature/59793 Add new icons for setting reminders op-alarm & op-alarm-set
#17497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consequently attempt to simplify the observable structure: hasReminder$ should emit based if notificationCountChanged$ | reminderModalUpdated$ emit i.e. if there's a new notification (from polling) or when the reminder modal is closed we want to recheck the reminderCount and subsequently update the icon
akabiru
changed the title
op-alarm & op-alarm-set
HDinger
approved these changes
Dec 19, 2024
akabiru
deleted the
feature/59793-create-new-icon-for-setting-reminders
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/59793
What are you trying to accomplish?
Update reminder icon from clock to new
op-alarmandop-alarm-seticons.Screenshots
WorkPackage Overview
Kapture.2024-12-19.at.00.09.08.mp4
Notification Centre
What approach did you choose and why?
Replace
reminderCount$:Observable<number>withhasReminder$:Observable<boolean>;further the hasReminder observable emission is standardised to depend on two actions:ReminderModalUpdatedandnotificationCountChangedMerge checklist