Include type in select to have correct behaviour in name method #17602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
bug/60563-users-are-shown-incorrectly-in-custom-field-filter-for-projects-of-type-user
branch
from
b7fdf0f to
d48d363
Compare
ulferts
deleted the
bug/60563-users-are-shown-incorrectly-in-custom-field-filter-for-projects-of-type-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/60563
What are you trying to accomplish?
Fix:
What approach did you choose and why?
Including the type in the select will lead to the correct class being instantiated which will cause the correct
#namemethod to be called.Merge checklist