-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[58427] Indicate that there are work package relations which the user has no permission to see #17604
Open
bsatarnejad
wants to merge
21
commits into
dev
Choose a base branch
from
58427-indicate-that-there-are-work-package-relations-which-the-user-has-no-permission-to-see
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+263
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mediator is responsible for providing the relations and children from a work package for the relations tab. This moves the responsibility of relations and children visibility in one central place.
…rning visible, invisible relations and their type
cbliard
force-pushed
the
code-maintenance/introduce-relations-tab-mediator
branch
from
January 15, 2025 15:03
a10a0be
to
b0ee80c
Compare
Base automatically changed from
code-maintenance/introduce-relations-tab-mediator
to
dev
January 15, 2025 15:25
…lations-which-the-user-has-no-permission-to-see
…lations-which-the-user-has-no-permission-to-see
…lations-which-the-user-has-no-permission-to-see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/58427
What are you trying to accomplish?
We want to show ghost relations of a WP in relations tab, but they will look different from visible relations.
Screenshots
What approach did you choose and why?
Return both visible and ghost relations to index component and then call relation component with different values for visible and ghost relations.
Merge checklist