Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/60449 reminders generate two or more lines for a work package in notification center clicking one selects all #17615

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Jan 15, 2025

Ticket

https://community.openproject.org/projects/communicator-stream/work_packages/60449/activity#activity-9

What are you trying to accomplish?

  • Aggregate the Reminder notifications with other notifications (regular aggregation) so that only one item per work package is visible in the notification center.
  • Add missing full stops to due dates
  • Elevate date alerts above actor mentions

Screenshots

Screenshot 2025-01-16 at 1 07 37 PM Screenshot 2025-01-16 at 1 09 43 PM Screenshot 2025-01-16 at 1 09 33 PM

What approach did you choose and why?

This reverts: #17426 where we previously defined reminder notifications as standalone.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

…on center, clicking one selects all

https://community.openproject.org/work_packages/60449

Aggregate the Reminder notifications with other notifications (regular aggregation) so that
only one item per work package is visible in the notification center.

This reverts: #17426 where we previously defined reminder notifications
as standalone.
@akabiru akabiru added the bugfix label Jan 15, 2025
@akabiru akabiru added this to the 15.2.x milestone Jan 15, 2025
@akabiru akabiru self-assigned this Jan 15, 2025
When there exists a reminder + date alert for a given WP, show the date
alert text + the reminder note
@akabiru akabiru force-pushed the bug/60449-reminders-generate-two-or-more-lines-for-a-work-package-in-notification-center-clicking-one-selects-all branch from a0dcb97 to 6f8e2cc Compare January 15, 2025 13:22
@akabiru akabiru force-pushed the bug/60449-reminders-generate-two-or-more-lines-for-a-work-package-in-notification-center-clicking-one-selects-all branch from 49d02b6 to 25d0b87 Compare January 15, 2025 14:30
@akabiru akabiru marked this pull request as ready for review January 16, 2025 10:32
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me. Plus I tested locally and it worked as expected.

Nice job 👍

@akabiru akabiru merged commit eb6b99f into release/15.2 Jan 17, 2025
15 checks passed
@akabiru akabiru deleted the bug/60449-reminders-generate-two-or-more-lines-for-a-work-package-in-notification-center-clicking-one-selects-all branch January 17, 2025 08:18
@akabiru akabiru removed the request for review from oliverguenther January 17, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants