SSO error handling #18111
Open
SSO error handling #18111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
sso-error-handling
branch
from
caa4402 to
65d1c83
Compare
NobodysNightmare
force-pushed
the
sso-error-handling
branch
2 times, most recently
from
9f35efa to
fb3bde7
Compare
Introducing an explicit difference between users that were never linked and those that have a link (i.e. a remote identity) but receive an authentication error anyways. There is also differentiation between SSO users and non-SSO users. When authenticating to the storage via SSO, it wouldn't make sense to show a login button to users.
The display would not work at all for SSO-only storages and would fail to recognize connections that didn't happen through a storage's oauth client. Now properly recognizing all remote identities and showing a special warning message when a non-connected user would connect through SSO.
NobodysNightmare
force-pushed
the
sso-error-handling
branch
from
fb3bde7 to
cf0ab3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
What are you trying to accomplish?
Fixing errors related to showing the connection status of SSO users to their storage.
In the files tab, the following cases should now be indicated correctly:
In the project storages member overview (e.g.
/projects/:name/settings/project_storages/:id/members):Which approach did you choose and why?
It occured to me, that the question of which authentication method will really be used for a user at a storage has to be asked in many different places. Thus I extracted the relevant code into a helper called
AuthenticationMethodSelector.Merge checklist