sysutils/beats8: initial Filebeat support #4591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdSchellevis
requested changes
Mar 16, 2025
There was a problem hiding this comment.
@0xThiebaut thanks, some small remarks from my end, but the rest looks good.
| </modules> | ||
| <inputs> | ||
| <enabled type="OptionField"> | ||
| <Default>audit</Default> |
There was a problem hiding this comment.
@AdSchellevis The constraint is technically that at least one of modules or inputs should be selected (otherwise filebeat is a no-op). Is there such a constraint?
Can't seem to immediately find something in Adding constraints.
There was a problem hiding this comment.
@0xThiebaut in these cases I usually prefer to extend the validation using performValidation(), for example dnsmasq has this.
call the parent:
make sure to return at the end:
and in the middle you can validate any rocket science you might need ;)
sysutils/beats8/src/opnsense/mvc/app/models/OPNsense/Beats8/Filebeat.xml
Outdated
Show resolved
Hide resolved
sysutils/beats8/src/opnsense/service/templates/OPNsense/Filebeat/filebeat.yml
Outdated
Show resolved
Hide resolved
sysutils/beats8/src/opnsense/service/templates/OPNsense/Filebeat/filebeat.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sysutils/beats8 plugin and initial Filebeat support enables OPNsense to send logs to Elasticsearch for further monitoring.
The plugin has the ability to collect the following OPNsense syslogs:
It also supports the Suricata module which, with opnsense/core#8442, allows OPNsense to perform decent network monitoring.
