Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked on #137, #277] Update Oppiabot dependencies #133

Open
vojtechjelinek opened this issue Oct 1, 2020 · 11 comments
Open

[Blocked on #137, #277] Update Oppiabot dependencies #133

vojtechjelinek opened this issue Oct 1, 2020 · 11 comments
Assignees
Labels

Comments

@vojtechjelinek
Copy link
Member

vojtechjelinek commented Oct 1, 2020

Update the versions of all the oppiabot dependencies, to keep them recent. This might help with the timeouts issue #136

@BenHenning
Copy link
Member

BenHenning commented Oct 1, 2020

@vojtechjelinek can you add context on which dependencies need to be updated & why? It's a bit hard to act upon this issue as-is.

@MohdImran001
Copy link

@vojtechjelinek Can I work on it?

@MohdImran001
Copy link

Hey @vojtechjelinek, I ran npm update to update dependencies to thier latest minor releases Then to check if everything is working fine I ran npm run test. I m getting the following output. But it is not showing which tests are failing. How I can find out failing tests?

487 specs, 0 failures
Finished in 89.019 seconds
----------------------------------|---------|----------|---------|---------|------------------------
File                              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------------------------------|---------|----------|---------|---------|------------------------
All files                         |     100 |    94.93 |     100 |     100 |
 oppiabot                         |     100 |    79.71 |     100 |     100 |
  constants.js                    |     100 |      100 |     100 |     100 |
  index.js                        |     100 |    79.71 |     100 |     100 | ...232-258,270,282-297
 oppiabot/actions/src             |     100 |      100 |     100 |     100 |
  dispatcher.js                   |     100 |      100 |     100 |     100 |
 oppiabot/actions/src/issues      |     100 |      100 |     100 |     100 |
  checkIssueLabels.js             |     100 |      100 |     100 |     100 |
 oppiabot/lib                     |     100 |    99.49 |     100 |     100 |
  apiForSheets.js                 |     100 |      100 |     100 |     100 |
  checkBranchPush.js              |     100 |      100 |     100 |     100 |
  checkCriticalPullRequest.js     |     100 |      100 |     100 |     100 |
  checkForNewCodeowner.js         |     100 |      100 |     100 |     100 |
  checkIssueAssignee.js           |     100 |      100 |     100 |     100 |
  checkMergeConflicts.js          |     100 |      100 |     100 |     100 |
  checkPullRequestBranch.js       |     100 |      100 |     100 |     100 |
  checkPullRequestJob.js          |     100 |      100 |     100 |     100 |
  checkPullRequestLabels.js       |     100 |      100 |     100 |     100 |
  checkPullRequestReview.js       |     100 |    97.06 |     100 |     100 | 242
  checkPullRequestTemplate.js     |     100 |      100 |     100 |     100 |
  checkWipDraftPR.js              |     100 |      100 |     100 |     100 |
  ciChecks.js                     |     100 |      100 |     100 |     100 |
  periodicChecks.js               |     100 |      100 |     100 |     100 |
  scheduler.js                    |     100 |      100 |     100 |     100 |
  staleBuildChecks.js             |     100 |      100 |     100 |     100 |
  utils.js                        |     100 |      100 |     100 |     100 |
 oppiabot/spec                    |     100 |      100 |     100 |     100 |
  apiForSheetsSpec.js             |     100 |      100 |     100 |     100 |
  checkBranchPushSpec.js          |     100 |      100 |     100 |     100 |
  checkCriticalPullRequestSpec.js |     100 |      100 |     100 |     100 |
  checkForNewCodeownerSpec.js     |     100 |      100 |     100 |     100 |
  checkIssueAssignedSpec.js       |     100 |      100 |     100 |     100 |
  checkIssueLabelsSpec.js         |     100 |      100 |     100 |     100 |
  checkMergeConflictSpec.js       |     100 |      100 |     100 |     100 |
  checkPullRequestBranchSpec.js   |     100 |      100 |     100 |     100 |
  checkPullRequestJobSpec.js      |     100 |      100 |     100 |     100 |
  checkPullRequestLabelsSpec.js   |     100 |      100 |     100 |     100 |
  checkPullRequestReviewSpec.js   |     100 |      100 |     100 |     100 |
  checkPullRequestTemplateSpec.js |     100 |      100 |     100 |     100 |
  checkWipDraftPRSpec.js          |     100 |      100 |     100 |     100 |
  ciChecksSpec.js                 |     100 |      100 |     100 |     100 |
  periodicChecksSpec.js           |     100 |      100 |     100 |     100 |
  staleBuildChecksSpec.js         |     100 |      100 |     100 |     100 |
  utilsSpec.js                    |     100 |      100 |     100 |     100 |
----------------------------------|---------|----------|---------|---------|------------------------

[@octokit/app] Deprecated. Use @octokit/app-auth instead. See https://github.com/octokit/app.js/#deprecated

Reverting .env
Tests failed.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test: `node ./spec/setup.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/skull/.npm/_logs/2021-03-21T15_46_31_406Z-debug.log

@vojtechjelinek
Copy link
Member Author

@jameesjohn Any help here?

@MohdImran001
Copy link

Hey @jameesjohn, please guide me about the above-mentioned error. I will really appreciate it.

@jameesjohn
Copy link
Contributor

Hi @MohdImran001
I'm not sure why it fails, it probably has something to do with

oppiabot/spec/setup.js

Lines 145 to 151 in a2b19c5

if (error) {
console.log(error);
reject();
}
if (stderr) {
console.log(stderr);
reject();

@mridul-netizen
Copy link
Contributor

Can you assign me this issue?

@mridul-netizen mridul-netizen self-assigned this May 18, 2021
jameesjohn pushed a commit that referenced this issue Jun 10, 2021
* updated

* @actions/core updated

* standard updated

* smee-client updated

* updated nodemon and nyc

* eslint jasmine lint-staged updated

* zeit ncc ,google auth, husky

* resolve conflicts

* dot env updated

* axios updated

* newrelic updated

* google apis updated

* updated

* updated

* updated

* updated

* updated

* revert index.js
@U8NWXD U8NWXD moved this from Triage to Not Started in Developer Workflow Team Nov 1, 2022
@seanlip seanlip added bug Something isn't working Impact: High Work: Medium and removed Priority: High labels Jan 6, 2023
@winnie368c
Copy link
Collaborator

@seanlip Can I be assigned to this?

@seanlip seanlip changed the title Update dependecies Update dependencies Apr 18, 2023
@seanlip seanlip changed the title Update dependencies Update Oppiabot dependencies Apr 18, 2023
@Shivkant-Chauhan Shivkant-Chauhan moved this from Todo to In Progress in Developer Workflow Team May 9, 2023
@winnie368c winnie368c removed their assignment May 13, 2023
@U8NWXD
Copy link
Member

U8NWXD commented May 20, 2023

Moving from high priority to priority since it isn't currently blocking developers

seanlip pushed a commit that referenced this issue Jun 23, 2023
* update some minor dependencies

* updated more dependencies

* updated dependencies

* update more dependencies

* update more dependencies

* update node

* rollback big changes

* rollback

* rollback axios

* print npm version

* print npm version

* check node version

* check node version

* check node version

* migrate node

* reupdate deps

* remove unnecessary changes

* latest setup node action

---------

Co-authored-by: Winnie Chen <[email protected]>
Co-authored-by: Winnie Chen <[email protected]>
Co-authored-by: Winnie Chen <[email protected]>
@seanlip
Copy link
Member

seanlip commented Jul 19, 2023

Note: @vojtechjelinek thinks this might not be possible until we fully move Oppiabot to update Probot, or move to GitHub Actions (see #137, #277) to remove the need for the Probot dependency.

@seanlip seanlip changed the title Update Oppiabot dependencies [Blocked on #137, #277] Update Oppiabot dependencies Jul 19, 2023
@Shivkant-Chauhan
Copy link

marking this as TODO as blocked on 137 and 277

@Shivkant-Chauhan Shivkant-Chauhan moved this from In Progress to Todo in Developer Workflow Team Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

10 participants