Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lint action with fork [skip preview] #2245

Conversation

NiklasBuchfink
Copy link
Member

Describe the changes you have conducted here

Preview the messages on https://inlang.com/github.com/NiklasBuchfink/monorepo .

Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: 3055585

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein
Copy link
Member

@NiklasBuchfink does forking require special logic? if you derive the link to be opened in fink with repo.getOrigin(), you should be good to go

@NiklasBuchfink
Copy link
Member Author

I get everything I need from github.context.payload.pull_request. I already generate the correct Fink link with it.

@janfjohannes recommend to keep the action simple (Checkout, loadProject, comment the lint summary or update if a comment already exists) and configure the scope within the workflow yaml to only run when the settings.json or the language files change.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants