-
Notifications
You must be signed in to change notification settings - Fork 38
[FSSDK-11464] chore: bump java sdk version 4.2.2 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request bumps the Java SDK version to 4.2.2 and updates the GitHub Actions Gradle cache strategy to support Nestpring and Java 17.
- Update of test dependencies to use a specific Mockito import
- Update of JVM target from Java 1.8 to 17 in build.gradle
- Inclusion of SLF4J API dependency in multiple modules and adjustments in GitHub workflow actions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
odp/src/androidTest/java/com/optimizely/ab/android/odp/DefaultODPApiManagerTest.kt | Replaces wildcard import from Mockito with specific import for mock |
odp/build.gradle | Updates jvmTarget to 17 and adds SLF4J dependency for both implementation and android tests |
android-sdk/build.gradle | Adds SLF4J dependency |
.github/workflows/build.yml | Upgrades GitHub Actions versions and revises Gradle cache setup |
.github/workflows/android.yml | Updates workflow reference to point to the new branch for the build workflow |
Comments suppressed due to low confidence (2)
odp/src/androidTest/java/com/optimizely/ab/android/odp/DefaultODPApiManagerTest.kt:23
- Switching from a wildcard import to a specific import may omit other needed Mockito functions. Please verify that all Mockito methods used in the tests are explicitly imported.
import org.mockito.Mockito.mock
odp/build.gradle:51
- Upgrading the JVM target to 17 is a good update, but please ensure that all dependencies and modules are fully compatible with Java 17 features.
jvmTarget = '17'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments but LGTM
Summary
The "why", or other context.
Test plan
Issues