[FSSDK-11731] windows version update #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates Windows runner versions across GitHub workflows to comply with IT standards, specifically updating from windows-2019 and windows-latest to windows-2022. The changes include adding .NET Framework reference assembly installation steps to maintain compatibility with older framework versions when using the newer Windows runner.
- Updated all Windows runners to use
windows-2022 - Added manual installation of .NET Framework 4.0 and 4.5 reference assemblies
- Removed the SonarQube workflow entirely
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/sonarqube.yml | Complete removal of SonarQube workflow |
| .github/workflows/csharp_release.yml | Updated runners to windows-2022 and added .NET Framework reference assembly installation |
| .github/workflows/csharp.yml | Updated runner to windows-2022 and added .NET Framework reference assembly installation with error tolerance |
mikechu-optimizely
requested changes
Aug 7, 2025
mikechu-optimizely
approved these changes
Aug 7, 2025
junaed-optimizely
deleted the
junaed/fssdk-11731-windows-update-in-build-system
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Windows version update to comply with IT standards
Test plan
Existing test should pass
Issues