Skip to content

[FSSDK-11649] Fix FSC failed tests for CMAB #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jun 27, 2025

The issue in the CMAB error handling path within the GetDecision method. When the CMAB API returns an error, the previous implementation attempted to append reasons from the failed API call to the accumulated reasons list. This caused FSC tests to fail because:

  • The reasons weren't properly propagated to downstream consumers
  • When API errors occurred, the Decision object contained incorrect or missing information
  • FSC tests expected specific error reasons to be present in the Decision object
    Fix
    Modified the error handling path to return a clean Decision object with properly initialized reasons

https://jira.sso.episerver.net/browse/FSSDK-11649

@Mat001 Mat001 self-assigned this Jun 27, 2025
@Mat001 Mat001 changed the title [FSSDK-11649] Fix CMAB error handling to properly propagate error reasons in Decisi… [FSSDK-11649] Fix FSC failed tests for CMAB Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant