[FSSDK-11140] Ruby: Update project config to track CMAB properties #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The new test is good, but you might add further tests for the new attribute lookup methods to verify error cases and edge cases.
raju-opti
approved these changes
Jun 13, 2025
| # Returns: | ||
| # Attribute corresponding to the provided attribute key. | ||
| attribute = @attribute_key_map[attribute_key] | ||
| return attribute if @attribute_key_map.key?(attribute_key) |
There was a problem hiding this comment.
I don't have much ruby knowledge, but I was curious whether we can refactor like this:
attribute = @attribute_key_map[attribute_key]
return attribute if attribute
Copilot says that will work
| # Returns: | ||
| # Attribute key corresponding to the provided attribute ID. | ||
| attribute = @attribute_id_to_key_map[attribute_id] | ||
| return attribute if @attribute_id_to_key_map.key?(attribute_id) |
lib/optimizely/helpers/constants.rb
Outdated
| }, | ||
| 'cmab' => { | ||
| 'type' => 'object', | ||
| 'items' => { |
There was a problem hiding this comment.
as cmab field is a single object, I guess items field is not appropriate. Also, we can probably specify the type of attributeIds.
update suggested by copilot
'cmab' => {
'type' => 'object',
'properties' => {
'attributeIds' => {
'type' => 'array',
'items' => { 'type' => 'string' }
},
'trafficAllocation' => {
'type' => 'integer'
}
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues