Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI by adding a version constraint #186

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Fix CI by adding a version constraint #186

merged 3 commits into from
Dec 20, 2024

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

This PR is to fix the CI.

Description of the changes

  • Add version constraint
  • Add a TODO comment to remove this version constraint once the new version of scikit-learn is released.

Additional Reference

@nabenabe0928
Copy link
Collaborator Author

@y0z
Ready for review, please merge this PR once you confirm the change!

The CI passed.

y0z
y0z approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit f23ff1d into optuna:main Dec 20, 2024
25 checks passed
@y0z y0z added the CI Continuous integration. label Dec 20, 2024
@y0z y0z added this to the v4.2.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0z y0z y0z approved these changes

Assignees

@y0z y0z

Labels
CI Continuous integration.
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nabenabe0928 @y0z