Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC libraries to optional dependencies #189

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Add gRPC libraries to optional dependencies #189

merged 1 commit into from
Dec 24, 2024

Conversation

not522
Copy link
Member

@not522 not522 commented Dec 24, 2024

Motivation

To fix the CI, this PR adds gPRC libraries to the optional dependencies.

Description of the changes

  • Install grpcio and protobuf for tests.

@not522 not522 added the CI Continuous integration. label Dec 24, 2024
@not522
Copy link
Member Author

not522 commented Dec 24, 2024

@nabenabe0928 Could you review this PR?

nabenabe0928
nabenabe0928 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM!

@nabenabe0928 nabenabe0928 merged commit 90982f6 into optuna:main Dec 24, 2024
123 checks passed
@not522 not522 deleted the fix-grpc-ci branch December 24, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabenabe0928 nabenabe0928 nabenabe0928 approved these changes

Assignees

@nabenabe0928 nabenabe0928

Labels
CI Continuous integration.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not522 @nabenabe0928