Remove all-element-non-negative check from user-prior CMA-ES #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this check is not necessary (and even malicious), I remove this check. I believe this check was simply forgotten to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this check is not necessary (and even malicious), I remove this check. I believe this check was simply forgotten to be removed.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Motivation
This PR is a bug fix.
Description of the changes
Since the covariance matrix of CMA-ES can contain negative values as well, e.g., think about the case where two variables have negative correlation, I removed the unnecessary check for this.