[JDK-8345428] Adapt JDK-8347147: [REDO] AccessFlags can be u2 in metadata #10271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
galahad-dev/JDK-8345428
branch
2 times, most recently
from
9d1e3a0 to
2cd4529
Compare
coleenp
reviewed
Jan 7, 2025
| helper.emitFinalReturn(JavaKind.Int, new AndNode(accessFlags, ConstantNode.forInt(config.jvmAccWrittenFlags))); | ||
| if (JavaVersionUtil.JAVA_SPEC == 21) { | ||
| helper.emitFinalReturn(JavaKind.Int, new AndNode(accessFlags, ConstantNode.forInt(config.jvmAccWrittenFlags))); | ||
| } else { |
There was a problem hiding this comment.
I removed ACC_WRITTEN_FLAGS also. All the access flags are the ones written in the classfile now.
There was a problem hiding this comment.
I see that now - it's checking against JDK 21.
|
I checked in the Hotspot version for this change just now. |
graalvmbot
force-pushed
the
galahad-dev/JDK-8345428
branch
from
2cd4529 to
1dcfc12
Compare
graalvmbot
changed the title
graalvmbot
force-pushed
the
galahad-dev/JDK-8345428
branch
from
1dcfc12 to
2c9d063
Compare
|
Hello team, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openjdk/jdk#22968 makes AccessFlags an unsigned short