refactor: run source code analysis by default #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Carl Flottmann <[email protected]>
art1f1c3R
force-pushed
the
art1f1c3R/sourcecode_remove_optional
branch
from
6312b0c to
542449d
Compare
Signed-off-by: Carl Flottmann <[email protected]>
Signed-off-by: Carl Flottmann <[email protected]>
tromai
reviewed
Jun 19, 2025
tromai
reviewed
Jun 19, 2025
tests/slsa_analyzer/checks/test_detect_malicious_metadata_check.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Carl Flottmann <[email protected]>
tromai
approved these changes
Jun 19, 2025
behnazh-w
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the requirement for source code analysis to have
--analyze-sourceto be enabled, making it a feature enabled by default. The--force-analyze-sourceoption still exists and functions as expected.Description of changes
Modifications to the relevant files handling command line options have been made to remove
--analyze-sourceas an option, and thedetect_malicious_metadata_check.pyhas been rewritten to include the source code analysis feature by default. The testtest_detect_malicious_metadata_check.pyhas been updated to reflect this.Checklist
verifiedlabel should appear next to all of your commits on GitHub.