Add Resource Providers for HCP Vault Dedicated #162
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -534,7 +565,786 @@ For the JSON type of provider (HCP Vault Dedicated, HCP Vault Secrets, HTTP/HTTP | |||
| - method | |||
| - optional parameters (depends on the cloud provider). | |||
|
|
|||
| ## Caching configuration | |||
| ## Dedicated Vault Username Provider | |||
There was a problem hiding this comment.
Missing a title for Resource Providers as there is for Config Providers
| <td> | ||
| The field inside the JSON secret that contains the required value. | ||
| If the secret contains multiple keys, this parameter specifies which key to extract. | ||
| If the secret contains only one key, the value is automatically used. |
There was a problem hiding this comment.
Is that the case event if a fieldName with a different value is provided?
| </table> | ||
|
|
||
| An example of a [connection properties file](https://docs.oracle.com/en/database/oracle/oracle-database/23/jajdb/oracle/jdbc/OracleConnection.html#CONNECTION_PROPERTY_CONFIG_FILE) that configures this provider can be found in [example-vault-secrets.properties](example-vault-secrets.properties). | ||
|
|
There was a problem hiding this comment.
We only support JSON values with multiple keys for dedicated vault and not for HCP? This question is valid for all resource providers
| <tr> | ||
| <td><code>type</code></td> | ||
| <td>The wallet format.</td> | ||
| <td>SSO, PKCS12, PEM</td> |
There was a problem hiding this comment.
Format the types as on the provider below
| <tr> | ||
| <td><code>fieldName</code> (Optional)</td> | ||
| <td> | ||
| The field inside the JSON secret that contains the required value. |
There was a problem hiding this comment.
Isn't the value supposed to be a wallet? Which JSON secret are we talking about here?
| <tr> | ||
| <td><code>fieldName</code> (Optional)</td> | ||
| <td> | ||
| The field inside the JSON secret that contains the required value. |
There was a problem hiding this comment.
Isn't this supposed to be tnsnames.ora file? Which JSON secret are we talking about here?
| new ResourceParameter("authenticationMethod", AUTHENTICATION_METHOD, | ||
| "auto-detect", | ||
| HcpVaultDedicatedResourceProvider::parseAuthenticationMethod), | ||
| new ResourceParameter("vaultAddr", VAULT_ADDR), |
There was a problem hiding this comment.
Could it be useful to create constants or and Enum instead?
| fileBytes = Base64.getDecoder().decode(secretBytes); | ||
| } else { | ||
| fileBytes = secretBytes; | ||
| } |
There was a problem hiding this comment.
I belive the code from line 85 to 93 is duplicated (several places), is it possible to create a method and call it instead?
No description provided.