-
Notifications
You must be signed in to change notification settings - Fork 6
Recipe to migrate artifactItem to Jakarta for the configuration of a maven plugin #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...c/main/java/com/oracle/weblogic/rewrite/jakarta/UpgradePluginConfigurationArtifactItems.java
Outdated
Show resolved
Hide resolved
rewrite-weblogic/src/main/resources/META-INF/rewrite/jakarta-ee-9.1.yaml
Outdated
Show resolved
Hide resolved
It seems fine overall, but here the new recipe is being added to the overall Jakarta migration recipe. Are we sure that we want to upgrade all plugin configurations that the user has automatically? @junior do you have any thoughts on this? |
The recipe is not upgrading all the plugins, it is upgrading the path /project/build/plugins/plugin/executions/execution/configuration/artifactItems/artifactItem and only when the groupId and artifactId mentioned in rewrite-weblogic/src/main/resources/META-INF/rewrite/jakarta-ee-9.1.yaml match the entries for an artifactItem. |
Looks good as well, but do we have use cases where the plugin does not get updated automatically with |
There is no recipe to transform this change. |
A new recipe is added to migrate groupId and artifactId of plugin -> executions -> execution -> configuration -> artifactItems -> artifactItem to Jakarta. The new plugin will be included under rewrite-maven of OpenRewrite in a follow-up change.