Skip to content

Recipe to migrate artifactItem to Jakarta for the configuration of a maven plugin #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025

Conversation

bhatpmk
Copy link
Member

@bhatpmk bhatpmk commented Jun 15, 2025

A new recipe is added to migrate groupId and artifactId of plugin -> executions -> execution -> configuration -> artifactItems -> artifactItem to Jakarta. The new plugin will be included under rewrite-maven of OpenRewrite in a follow-up change.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 15, 2025
@bhatpmk bhatpmk changed the title Migrate artifactItem to Jakarta for the configuration of a maven plugin Recipe to migrate artifactItem to Jakarta for the configuration of a maven plugin Jun 15, 2025
@bhatpmk bhatpmk requested a review from desagar June 16, 2025 12:53
@desagar
Copy link
Member

desagar commented Jun 17, 2025

It seems fine overall, but here the new recipe is being added to the overall Jakarta migration recipe. Are we sure that we want to upgrade all plugin configurations that the user has automatically? @junior do you have any thoughts on this?

@bhatpmk
Copy link
Member Author

bhatpmk commented Jun 17, 2025

It seems fine overall, but here the new recipe is being added to the overall Jakarta migration recipe. Are we sure that we want to upgrade all plugin configurations that the user has automatically? @junior do you have any thoughts on this?

The recipe is not upgrading all the plugins, it is upgrading the path /project/build/plugins/plugin/executions/execution/configuration/artifactItems/artifactItem and only when the groupId and artifactId mentioned in rewrite-weblogic/src/main/resources/META-INF/rewrite/jakarta-ee-9.1.yaml match the entries for an artifactItem.

@junior
Copy link
Member

junior commented Jun 18, 2025

It seems fine overall, but here the new recipe is being added to the overall Jakarta migration recipe. Are we sure that we want to upgrade all plugin configurations that the user has automatically? @junior do you have any thoughts on this?

The recipe is not upgrading all the plugins, it is upgrading the path /project/build/plugins/plugin/executions/execution/configuration/artifactItems/artifactItem and only when the groupId and artifactId mentioned in rewrite-weblogic/src/main/resources/META-INF/rewrite/jakarta-ee-9.1.yaml match the entries for an artifactItem.

Looks good as well, but do we have use cases where the plugin does not get updated automatically with mvn package/compile/deploy ? I could not find any similar recipe

@desagar desagar self-assigned this Jun 18, 2025
@bhatpmk
Copy link
Member Author

bhatpmk commented Jun 18, 2025

It seems fine overall, but here the new recipe is being added to the overall Jakarta migration recipe. Are we sure that we want to upgrade all plugin configurations that the user has automatically? @junior do you have any thoughts on this?

The recipe is not upgrading all the plugins, it is upgrading the path /project/build/plugins/plugin/executions/execution/configuration/artifactItems/artifactItem and only when the groupId and artifactId mentioned in rewrite-weblogic/src/main/resources/META-INF/rewrite/jakarta-ee-9.1.yaml match the entries for an artifactItem.

Looks good as well, but do we have use cases where the plugin does not get updated automatically with mvn package/compile/deploy ? I could not find any similar recipe

There is no recipe to transform this change.

@bhatpmk bhatpmk merged commit 6418127 into main Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants