[Feat] Composer module #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And hide internal components DI token
That will return all available components in orchestrator
By replacing Object.values => Object.keys
And use localized imports of modules
And add missing layout module import to unit tests
Of LOCAL_UPDATE_CONFIG token
gund
force-pushed
the
feat-composer-module
branch
from
e118002 to
19aedc1
Compare
And reset component state when it has to be changed but kept due to tracking optimizations
And render config in a card component with controls in popver
So only one component has it's popover active at a time
To unload droppable component
So they can be extended via DI from third-party modules re orchestratora/rfcs#2
And update list of used peer dependencies
gund
commented
Jan 15, 2022
| @@ -2,22 +2,32 @@ import { Type } from '@angular/core'; | |||
|
|
|||
| import { createMetadataGetSet } from './util'; | |||
|
|
|||
| export interface ConfigurationMeta { | |||
| const Reflect = (window as any).Reflect; | |||
There was a problem hiding this comment.
User should be able to provide Reflect API differently otherwise default back to getting it from global window.
For example:
https://github.com/orchestratora/gen-io-ts/blob/6f8d6565809100c05fef809fa38942e7086b01d2/projects/gen-io-ts/src/lib/reflect.ts
NOTE: Ideally Reflect API should be shared between libs like @orchestratora/gen-io-ts.
Update composer module PR #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements orchestratora/rfcs#2