New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added the "confirm" attribute to the property translations #2976

Merged

tabuna merged 1 commit into orchidsoftware:master from xav-developer:fix-button-translations

Mar 21, 2025

Contributor

xav-developer commented Mar 19, 2025

Fixes #

Proposed Changes

Pass the text for translation to the "confirm" method of the "Button" class

Before:

            Button::make('Title')
                ->icon('bs.trash3')
                ->confirm(__('Conformation'))
                ->method('destroy')
                ->canSee($this->model->exists),

After:

            Button::make('Title')
                ->icon('bs.trash3')
                ->confirm('Conformation')
                ->method('destroy')
                ->canSee($this->model->exists),


          Fix: Added the "confirm" attribute to the property translations

fe4c70a

tabuna merged commit 31e5f71 into orchidsoftware:master

44 of 46 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet