Check the real unknown attributes when applying vector #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will check it out on friday! |
Separated detection for CVSS:3.0 and CVSS:3.1.
|
I added a few test cases just to ensure everything is still working, but it looks fine. If everything still looks good to you @xaldama, I'd be happy to merge it! |
YanWittmann
approved these changes
Dec 20, 2024
|
@xaldama: Thank you very much for your contribution. While this time the changes are not tremendous, we nevertheless need a signed CLA from you before we can accept and merge the changes. Would you mind sending us a signed copy of the rendered content in CLA.md. We need this agreement from everybody committing outside of our organization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to get the vector from a vector string using CvssVector.parseVector, the method tries to infer the CVSS version from the attributes.
parseVectorOnlyIfKnownAttributes call to applyVector method, which returns the number of attributes applied, but it is expecting to get the unknown ones.
This PR checks if there is any attribute that was not applied to the vector.
I splited applyVector not to duplicate code.