Skip to content

docs: onboarding portal #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 11, 2025
Merged

docs: onboarding portal #2181

merged 22 commits into from
Jun 11, 2025

Conversation

niwsa
Copy link
Contributor

@niwsa niwsa commented May 27, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 27, 2025

CLA assistant check
All committers have signed the CLA.

@niwsa niwsa changed the title feat: onboarding portal docs: onboarding portal Jun 2, 2025
@niwsa niwsa marked this pull request as ready for review June 2, 2025 06:08
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Jun 2, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Only nit is the (preview) in the heading here - I would omit that since we often forget to remove it...
better to have the tag in the console (as the SS shows) and then also mention it in the note there. But its a nit so not super important...

I added the upstream label since I take this is waiting for a release still

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go 🐝

let me know when the docs are in reviewable state - normally they are ready to review when out of draft, but you are still changing things so I was not sure if I should wait.
If they are ready to review let me know - looks great so far, but I would tweak the text a little bit.

this is not connected to the admin portal in any way I assume?

@niwsa niwsa requested a review from vinckr June 10, 2025 10:16
@niwsa niwsa removed the no-close Do not close this. label Jun 10, 2025
@niwsa niwsa merged commit bcf9bdf into master Jun 11, 2025
8 checks passed
@niwsa niwsa deleted the onboarding-portal branch June 11, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants