Skip to content

chore: properly resolve ory:// in config editor #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2025

Conversation

jonas-jonas
Copy link
Member

Fixes #1901

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

the preview is a bit mangled but the config editor works fine.

local preview and build looks fine - looks like the same as in #2193

do you think its safe to merge?

@jonas-jonas
Copy link
Member Author

No, probably not safe to merge. Looks like docusaurus changed something wrt custom styling. I'll take a look

@vinckr
Copy link
Member

vinckr commented Jun 3, 2025

could be this maybe 🤔 facebook/docusaurus#10945

@vinckr vinckr self-requested a review June 5, 2025 07:10
@vinckr
Copy link
Member

vinckr commented Jun 5, 2025

last commit fixed most of it, the network CTA is still bork @jonas-jonas

@jonas-jonas jonas-jonas requested review from vinckr and removed request for vinckr June 5, 2025 12:17
@aeneasr aeneasr merged commit f995340 into master Jun 6, 2025
9 checks passed
@aeneasr aeneasr deleted the jonas-jonas/configEditorFix branch June 6, 2025 10:14
@vinckr
Copy link
Member

vinckr commented Jun 6, 2025

the sidebar, topbar, and TOC links have the wrong colour - they should be normal text colour not blueish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra configuration editor is broken
3 participants