Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: homogenize testids #332

Merged
merged 3 commits into from
Jan 18, 2025
Merged

chore: homogenize testids #332

merged 3 commits into from
Jan 18, 2025

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 17, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.80%. Comparing base (f3fad4d) to head (b0ce7b8).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   42.43%   42.80%   +0.37%     
==========================================
  Files         136      138       +2     
  Lines        2008     2065      +57     
  Branches      288      303      +15     
==========================================
+ Hits          852      884      +32     
- Misses       1149     1172      +23     
- Partials        7        9       +2     
Components Coverage Δ
@ory/elements-react 37.44% <40.47%> (+0.65%) ⬆️
@ory/nextjs 65.97% <ø> (ø)

@aeneasr aeneasr requested a review from jonas-jonas January 17, 2025 16:55
@aeneasr aeneasr merged commit ab13878 into main Jan 18, 2025
13 checks passed
@aeneasr aeneasr deleted the clean-testid branch January 18, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants