Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show loading indicator on clicked button #335

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Jan 21, 2025

Screen.Recording.2025-01-21.at.11.51.03.AM.mov

Related Issue or Design Document

Closes #329

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 42.61%. Comparing base (f3fad4d) to head (9bbf36b).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   42.43%   42.61%   +0.18%     
==========================================
  Files         136      138       +2     
  Lines        2008     2079      +71     
  Branches      288      306      +18     
==========================================
+ Hits          852      886      +34     
- Misses       1149     1184      +35     
- Partials        7        9       +2     
Components Coverage Δ
@ory/elements-react 37.25% <36.73%> (+0.46%) ⬆️
@ory/nextjs 65.97% <ø> (ø)

@jonas-jonas jonas-jonas merged commit 1cb3be1 into main Jan 22, 2025
16 of 17 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/loadingState branch January 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only mark the clicked button as loading
3 participants