-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop PR title validation #32
Comments
Right now it specify release/feature type. So it will be much more difficult to understand what type of release we have, how to generate change logs and so on. So I assume I’ll be a releaser of Oryx, and in case we drop it - it will make my life more difficult, I’ll need to adjust some scripts and also analyze every merged PR separetly before release. So I strongly do not recommend it for now. Maybe we can think about automation for it, but as long as we don't have public API really specified it looks like a big feature. |
@tolerants if you are afraid of complex release process, maybe we can just use Github labels for marking Features/Bug/Enhancement in PRs? Then we can still drop this not-friedly automation. |
@PhilinTv But we are not able to get github labels in git. So again in this case we have to check all the PR's manually or create a small script to gather this information (maybe there is a github action for it). Maybe we can at least put a small explanation into PR template regarding conventional commits so it will slightly improve an experience for contributors? |
@tolerants even at this simple doc case there are plenty of nuances :)
Why do you need this information in Git? We would typically write BC-breaks in the GH release notes. PS. Somehow these guys manage it without "chore" schema 😄 |
@PhilinTv Vercel is having different release process. Like every other library. |
WE Removed title validation for now. |
While at some teams prefixes like "chore" to commits and PRs are a daily business, they create problems for newbie contirbutors.
And while they create additional challenges, their value is not that high.
WDYT, about removing additional commit and PR title validations?
The text was updated successfully, but these errors were encountered: