Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed internal release process doc #38

Merged

Conversation

tolerants
Copy link
Contributor

@tolerants tolerants commented Jun 18, 2024

  • Removed release process internal doc
  • Fixed ci for PR's from forked repos
  • Disabled visual checks as long as we can't use secrets in the context of forked repo

@tolerants tolerants requested a review from a team as a code owner June 18, 2024 09:30
Copy link

netlify bot commented Jun 18, 2024

👷 Deploy request for dev-composable-storefront pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e946a28

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for dev-oryx-components canceled.

Name Link
🔨 Latest commit e946a28
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6673dc5bbafeaf0008562710

@PhilinTv
Copy link
Contributor

If we don't request for PR title from contributors - let's skip it completely. I don't see a reason to check it "sometimes".
Also closing [https://github.com//issues/32](the issue).

PS This PR should be "chore" 😄

@tolerants tolerants changed the title docs: removed internal release process doc chore: removed internal release process doc Jun 19, 2024
@tolerants
Copy link
Contributor Author

@PhilinTv

If we don't request for PR title from contributors - let's skip it completely. I don't see a reason to check it "sometimes".
Also closing [https://github.com/https://github.com//issues/32](the issue).

Agree, removed.

PS This PR should be "chore" 😄

Yeah, initially it was about docs, but with all the changes related to ci - it's a chore.

- name: Set should-run for PR
id: set-env
run: |
echo "CHROMATIC_PROJECT_TOKEN=${{ secrets.CHROMATIC_PROJECT_TOKEN }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments

PhilinTv
PhilinTv previously approved these changes Jun 19, 2024
@tolerants tolerants merged commit a7cd512 into oryx-frontend:development Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants